Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace dioxus-sdk with dioxus-clipboard #973

Merged
merged 4 commits into from
Oct 13, 2024

Conversation

marc2332
Copy link
Owner

@marc2332 marc2332 commented Oct 9, 2024

No description provided.

@marc2332 marc2332 added the internal impovement👍 Internal code improvements label Oct 9, 2024
@marc2332 marc2332 changed the title chore: Fixes and clean up chore: Replace dioxus-sdk with dioxus-clipboard Oct 9, 2024
@marc2332 marc2332 force-pushed the chore/replace-dioxus-sdk-with-dioxus-clipboard branch from 243e0ce to a1c37ac Compare October 9, 2024 12:48
@marc2332 marc2332 added this to the 0.3.0 milestone Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

Benchmark for 3d9d588

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 110.2±1.09ms 109.8±0.97ms -0.36%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 28.8±3.05ms 28.7±4.19ms -0.35%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1417.4±19.39µs 1433.2±15.55µs +1.11%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 138.5±12.01µs 136.2±2.15µs -1.66%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 27.7±2.91ms 27.2±1.97ms -1.81%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 2.2±0.30ms 1909.1±110.00µs -13.22%
benchmarks/size=19531 depth=7 wide=5 mode=cached 392.9±28.23µs 369.1±14.01µs -6.06%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 3.0±0.25ms 3.0±0.22ms 0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 422.3±80.01µs 422.3±76.46µs 0.00%
benchmarks/size=54241 depth=5 wide=15 mode=cached 381.7±67.28µs 384.5±80.92µs +0.73%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 7.1±0.33ms 7.4±0.41ms +4.23%

Copy link

github-actions bot commented Oct 9, 2024

Benchmark for 7b248eb

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 105.5±0.69ms 106.1±0.80ms +0.57%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 23.9±0.63ms 24.3±1.10ms +1.67%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1407.4±17.02µs 1400.0±17.61µs -0.53%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 133.9±1.63µs 137.9±13.04µs +2.99%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 23.8±0.54ms 23.7±0.44ms -0.42%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1721.6±52.30µs 1715.9±33.93µs -0.33%
benchmarks/size=19531 depth=7 wide=5 mode=cached 313.6±13.29µs 316.1±19.28µs +0.80%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.6±0.08ms 2.6±0.04ms 0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 417.1±71.70µs 417.4±109.87µs +0.07%
benchmarks/size=54241 depth=5 wide=15 mode=cached 252.3±19.33µs 255.5±28.46µs +1.27%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.4±0.06ms 6.4±0.17ms 0.00%

Copy link

github-actions bot commented Oct 9, 2024

Benchmark for 4cd5c1d

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 105.3±0.77ms 106.5±0.61ms +1.14%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 23.6±0.83ms 24.4±1.39ms +3.39%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1424.2±41.01µs 1443.6±58.49µs +1.36%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 135.7±0.97µs 136.9±7.01µs +0.88%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 23.9±0.40ms 24.0±0.41ms +0.42%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1761.6±65.77µs 1763.2±122.62µs +0.09%
benchmarks/size=19531 depth=7 wide=5 mode=cached 311.2±11.44µs 311.0±11.16µs -0.06%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.6±0.02ms 2.6±0.10ms 0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 419.0±130.16µs 422.0±130.85µs +0.72%
benchmarks/size=54241 depth=5 wide=15 mode=cached 249.0±18.71µs 246.0±19.96µs -1.20%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.4±0.27ms 6.8±0.18ms +6.25%

Copy link

github-actions bot commented Oct 9, 2024

Benchmark for 61422ce

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 107.5±2.67ms 108.0±1.87ms +0.47%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 25.4±1.13ms 26.0±1.50ms +2.36%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1428.9±19.74µs 1440.4±13.77µs +0.80%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 135.3±1.03µs 134.1±1.31µs -0.89%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 27.8±0.94ms 26.2±0.51ms -5.76%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1773.4±46.99µs 1828.6±121.40µs +3.11%
benchmarks/size=19531 depth=7 wide=5 mode=cached 365.6±18.95µs 358.0±27.76µs -2.08%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.7±0.06ms 2.7±0.09ms 0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 418.0±2.74µs 420.4±84.15µs +0.57%
benchmarks/size=54241 depth=5 wide=15 mode=cached 283.1±42.02µs 374.2±74.81µs +32.18%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.6±0.17ms 6.6±0.36ms 0.00%

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.00%. Comparing base (1c9d579) to head (f9a48c4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #973   +/-   ##
=======================================
  Coverage   74.00%   74.00%           
=======================================
  Files         213      213           
  Lines       24324    24324           
=======================================
  Hits        18001    18001           
  Misses       6323     6323           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332 marc2332 merged commit 65a8be7 into main Oct 13, 2024
7 checks passed
@marc2332 marc2332 deleted the chore/replace-dioxus-sdk-with-dioxus-clipboard branch October 13, 2024 11:51
Copy link

Benchmark for 9f9a9e5

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 105.8±0.54ms 105.8±0.81ms 0.00%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 24.0±0.82ms 25.2±1.48ms +5.00%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1421.5±21.65µs 1422.1±41.14µs +0.04%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 134.6±1.94µs 135.6±1.37µs +0.74%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 24.1±0.73ms 23.7±0.42ms -1.66%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1726.2±37.95µs 1751.7±40.99µs +1.48%
benchmarks/size=19531 depth=7 wide=5 mode=cached 316.1±8.18µs 312.9±4.07µs -1.01%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.6±0.02ms 2.6±0.01ms 0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 418.4±82.45µs 418.0±77.20µs -0.10%
benchmarks/size=54241 depth=5 wide=15 mode=cached 281.0±149.03µs 253.9±24.56µs -9.64%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.3±0.11ms 6.4±0.14ms +1.59%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal impovement👍 Internal code improvements
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant