Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freezer: change the order to fix bugs with patchelf #2620

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

marcelotduarte
Copy link
Owner

@marcelotduarte marcelotduarte commented Oct 10, 2024

Fixes #2508
As far as I can tell, there are some issues with patchelf regarding the order in which modifications are made, so despite using only --rpath and --needed, the information in two issues helped me find a solution:
NixOS/patchelf#446
NixOS/patchelf#524

When issue 2508 was posted, I could not reproduce it on GHA, but two days ago I had the same error, so I could reproduce it using manylinux Python.
The error can be reproduced with files linked against Python 3.9 and 3.10.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 58.95%. Comparing base (7ec2cb4) to head (023a15a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cx_Freeze/parser.py 0.00% 7 Missing ⚠️
cx_Freeze/freezer.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2620      +/-   ##
==========================================
- Coverage   59.02%   58.95%   -0.07%     
==========================================
  Files          27       27              
  Lines        4288     4293       +5     
==========================================
  Hits         2531     2531              
- Misses       1757     1762       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linux builds have started failing since updating to 7.2
1 participant