Skip to content

Commit

Permalink
Bug 1918664 [wpt PR 48155] - Implement RTCRtpEncodingParameters.scale…
Browse files Browse the repository at this point in the history
…ResolutionDownTo., a=testonly

Automatic update from web-platform-tests
Implement RTCRtpEncodingParameters.scaleResolutionDownTo.

Spec: https://w3c.github.io/webrtc-extensions/#dom-rtcrtpencodingparameters-scaleresolutiondownto

Wires up scaleResolutionDownTo[1] to JS behind RuntimeEnabled flag
"RTCRtpScaleResolutionDownTo". This is implemented in third_party/webrtc
where it is called `requested_resolution`.

WPTs are added to test basic functionality, including getting the
resolution we expect, changing it on the fly, it being orientation
agnostic and throwing on invalid parameters.

The tests use small resolutions like 120x60 for fast ramp up even on
slow bots (sending HD tends to trigger initial frame dropping and slow
BW ramp up).

The following test coverage is NOT included yet, but will be added in
follow up CL(s):
- Simulcast tests: to be written in a separate CL for reviewability.
- scaleTo maintaining aspect ratio: blocked on a WebRTC fix.

[1] w3c/webrtc-extensions#221

Bug: chromium:363544347
Change-Id: If930ffd686d073d2eb239763e9ea9c1390fbcef1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5828607
Reviewed-by: Dominik Röttsches <drottchromium.org>
Commit-Queue: Henrik Boström <hboschromium.org>
Reviewed-by: Harald Alvestrand <htachromium.org>
Cr-Commit-Position: refs/heads/main{#1355122}

--

wpt-commits: 85dc128fe5ac6c48d09609411808de0939feb31f
wpt-pr: 48155

UltraBlame original commit: 2853f7cfdf43cb7e21a4811e96435bfda1edc9fd
  • Loading branch information
marco-c committed Sep 20, 2024
1 parent 5ce22a1 commit 2b6f752
Showing 1 changed file with 1,971 additions and 0 deletions.
Loading

0 comments on commit 2b6f752

Please sign in to comment.