Add IBM Power Cloud support #718
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amvasilyev
requested changes
Oct 4, 2024
| @@ -16,6 +16,8 @@ def initialize(shared_disks, configuration_path, env, logger) | |||
| def create_libvirt_disk_images(shared_disks) | |||
| image_dir_path = "#{@configuration_path}/images" | |||
| FileUtils.mkdir_p(image_dir_path) | |||
| FileUtils.chmod 0775, image_dir_path, :verbose => true | |||
There was a problem hiding this comment.
This change should not be shown. Please rebase this branch on top of integration.
| end | ||
|
|
||
| def iam_token | ||
| command = "curl -k -X POST \ |
There was a problem hiding this comment.
Use net::http library to make HTTP calls instead of calling curl command: https://ruby-doc.org/3.3.5/stdlibs/net/Net/HTTP.html
| @@ -41,7 +43,11 @@ def destroy_nodes(nodes, path, provider, configuration_id) | |||
|
|
|||
| @ui.info('Destroying the machines using terraform') | |||
| result = TerraformService.resource_type(provider).and_then do |resource_type| | |||
| resources = TerraformService.nodes_to_resources(nodes, resource_type).values | |||
| if resource_type == "ibm_pi_instance" | |||
| resources = TerraformService.ibm_nodes_to_resources(nodes) | |||
There was a problem hiding this comment.
Please pin extra dependencies in generated terraform file with correct depends_on signature: https://developer.hashicorp.com/terraform/tutorials/configuration-language/dependencies
amvasilyev
requested changes
Oct 4, 2024
| } | ||
| }, | ||
|
|
||
| "rhel_9_ibm": { |
There was a problem hiding this comment.
Please split examples into a set of JSON documents. MDBCI can not support different providers in one template.
nazarovdo
force-pushed
the
fruc-116-ibm-cloud
branch
2 times, most recently
from
4674c01
to
e747364
Compare
nazarovdo
force-pushed
the
fruc-116-ibm-cloud
branch
from
e747364
to
c8e0073
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.