fix(can_have_fallbacks): use ConvenientService.raise

marian13 · Jun 3, 2024 · 148317d · 148317d
1 parent a19ce55
commit 148317d
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 1 deletion.
diff --git a/...ice/service/plugins/can_have_steps/entities/step/plugins/can_have_fallbacks/middleware.rb b/...ice/service/plugins/can_have_steps/entities/step/plugins/can_have_fallbacks/middleware.rb
@@ -130,7 +130,7 @@ def service
                   def refute_method_step!
                     return unless step.method_step?
 
-                    raise Exceptions::MethodStepCanNotHaveFallback.new(step: step)
+                    ::ConvenientService.raise Exceptions::MethodStepCanNotHaveFallback.new(step: step)
                   end
                 end
               end

diff --git a/...ervice/plugins/can_have_steps/entities/step/plugins/can_have_fallbacks/middleware_spec.rb b/...ervice/plugins/can_have_steps/entities/step/plugins/can_have_fallbacks/middleware_spec.rb
@@ -299,6 +299,11 @@ def foo
                     .to raise_error(ConvenientService::Service::Plugins::CanHaveSteps::Entities::Step::Plugins::CanHaveFallbacks::Exceptions::MethodStepCanNotHaveFallback)
                     .with_message(exception_message)
                 end
+
+                specify do
+                  expect { ignoring_exception(ConvenientService::Service::Plugins::CanHaveSteps::Entities::Step::Plugins::CanHaveFallbacks::Exceptions::MethodStepCanNotHaveFallback) { method_value } }
+                    .to delegate_to(ConvenientService, :raise)
+                end
               end
             end
 
@@ -512,6 +517,11 @@ def foo
                     .to raise_error(ConvenientService::Service::Plugins::CanHaveSteps::Entities::Step::Plugins::CanHaveFallbacks::Exceptions::MethodStepCanNotHaveFallback)
                     .with_message(exception_message)
                 end
+
+                specify do
+                  expect { ignoring_exception(ConvenientService::Service::Plugins::CanHaveSteps::Entities::Step::Plugins::CanHaveFallbacks::Exceptions::MethodStepCanNotHaveFallback) { method_value } }
+                    .to delegate_to(ConvenientService, :raise)
+                end
               end
             end
 
@@ -753,6 +763,11 @@ def foo
                     .to raise_error(ConvenientService::Service::Plugins::CanHaveSteps::Entities::Step::Plugins::CanHaveFallbacks::Exceptions::MethodStepCanNotHaveFallback)
                     .with_message(exception_message)
                 end
+
+                specify do
+                  expect { ignoring_exception(ConvenientService::Service::Plugins::CanHaveSteps::Entities::Step::Plugins::CanHaveFallbacks::Exceptions::MethodStepCanNotHaveFallback) { method_value } }
+                    .to delegate_to(ConvenientService, :raise)
+                end
               end
             end
 
@@ -943,6 +958,11 @@ def foo
                   .to raise_error(ConvenientService::Service::Plugins::CanHaveSteps::Entities::Step::Plugins::CanHaveFallbacks::Exceptions::MethodStepCanNotHaveFallback)
                   .with_message(exception_message)
               end
+
+              specify do
+                expect { ignoring_exception(ConvenientService::Service::Plugins::CanHaveSteps::Entities::Step::Plugins::CanHaveFallbacks::Exceptions::MethodStepCanNotHaveFallback) { method_value } }
+                  .to delegate_to(ConvenientService, :raise)
+              end
             end
           end
 
@@ -1178,6 +1198,11 @@ def foo
                   .to raise_error(ConvenientService::Service::Plugins::CanHaveSteps::Entities::Step::Plugins::CanHaveFallbacks::Exceptions::MethodStepCanNotHaveFallback)
                   .with_message(exception_message)
               end
+
+              specify do
+                expect { ignoring_exception(ConvenientService::Service::Plugins::CanHaveSteps::Entities::Step::Plugins::CanHaveFallbacks::Exceptions::MethodStepCanNotHaveFallback) { method_value } }
+                  .to delegate_to(ConvenientService, :raise)
+              end
             end
           end