Skip to content

Commit

Permalink
fix: inconsistent naming of SelectList (#3924)
Browse files Browse the repository at this point in the history
* fix: inconsistent naming of `SelectList`

* Create tidy-sloths-trade.md
  • Loading branch information
sebald authored May 28, 2024
1 parent f008691 commit 290dc0e
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 6 deletions.
6 changes: 6 additions & 0 deletions .changeset/tidy-sloths-trade.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@marigold/docs": patch
"@marigold/components": patch
---

fix: inconsistent naming of `SelectList`
6 changes: 3 additions & 3 deletions docs/content/components/collection/selectlist/selectlist.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ import { SelectList } from '@marigold/components';
},
{
property: 'renderEmptyState',
type: '(props: GridListRenderProps) => React.ReactNode',
type: '(props: SelectListRenderProps) => React.ReactNode',
description:
'Provides content to display when there are no items in the list.',
default: 'none',
Expand Down Expand Up @@ -93,7 +93,7 @@ import { SelectList } from '@marigold/components';
property: 'dragAndDropHooks',
type: 'DragAndDropHooks | undefined',
description:
'The drag and drop hooks returned by useDragAndDrop used to enable drag and drop behavior for the GridList.',
'The drag and drop hooks returned by useDragAndDrop used to enable drag and drop behavior for the SelectList.',
default: 'none',
},
{
Expand Down Expand Up @@ -155,7 +155,7 @@ import { SelectList } from '@marigold/components';
},
{
property: 'renderEmptyState',
type: '(props: GridListRenderProps) => React.ReactNode',
type: '(props: SelectListRenderProps) => React.ReactNode',
description:
'Provides content to display when there are no items in the list.',
default: 'none',
Expand Down
6 changes: 3 additions & 3 deletions packages/components/src/SelectList/SelectList.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import { SelectListItem } from './SelectListItem';

type RemoveProps = 'style' | 'className' | 'onSelectionChange';

export interface GridListProps
export interface SelectListProps
extends Omit<RAC.GridListProps<object>, RemoveProps> {
onChange?:
| RAC.GridListProps<object>['onSelectionChange']
Expand All @@ -25,12 +25,12 @@ export interface GridListProps

interface SelectListComponent
extends ForwardRefExoticComponent<
GridListProps & RefAttributes<HTMLUListElement>
SelectListProps & RefAttributes<HTMLUListElement>
> {
Item: typeof SelectListItem;
}

const _SelectList = forwardRef<HTMLUListElement, GridListProps>(
const _SelectList = forwardRef<HTMLUListElement, SelectListProps>(
({ onChange, ...rest }, ref) => {
const classNames = useClassNames({ component: 'ListBox' });

Expand Down

0 comments on commit 290dc0e

Please sign in to comment.