Skip to content

Commit

Permalink
fix: add placeholder prop to Combobox types (#3715)
Browse files Browse the repository at this point in the history
* fix: add placeholder to `Combobox`

* add to docu

* Create spicy-planes-warn.md
  • Loading branch information
sebald authored Feb 14, 2024
1 parent 2b9e03e commit 7969fd9
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 0 deletions.
6 changes: 6 additions & 0 deletions .changeset/spicy-planes-warn.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@marigold/docs": patch
"@marigold/components": patch
---

fix: add placeholder prop to `Combobox` types
6 changes: 6 additions & 0 deletions docs/content/components/form/combobox/combobox.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,12 @@ import { ComboBox } from '@marigold/components';
description:
"The label text. If you don't want to visually display a label, provide an `aria-label` or `aria-labelledby` attribute for accessibility.",
},
{
property: 'placeholder',
type: 'string',
description: 'Set the placeholder for the select.',
default: 'none',
},
{
property: 'defaultValue',
type: 'string',
Expand Down
1 change: 1 addition & 0 deletions packages/components/src/ComboBox/ComboBox.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ export interface ComboBoxProps
value?: RAC.ComboBoxProps<any>['inputValue'];
onChange?: RAC.ComboBoxProps<any>['onInputChange'];
children: ReactNode | ((item: any) => ReactNode);
placeholder?: string;
}

interface ComboBoxComponent
Expand Down

0 comments on commit 7969fd9

Please sign in to comment.