Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add onChange documentation in dev guidelines #3643

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

sarahgm
Copy link
Member

@sarahgm sarahgm commented Jan 17, 2024

No description provided.

Copy link

changeset-bot bot commented Jan 17, 2024

⚠️ No Changeset found

Latest commit: 0782c82

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marigold-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2024 10:16am
marigold-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2024 10:16am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
marigold-production ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2024 10:16am

@github-actions github-actions bot added the type:docs Improvements or additions to documentation label Jan 17, 2024
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (05c158f) 99.82% compared to head (0782c82) 99.82%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3643   +/-   ##
=======================================
  Coverage   99.82%   99.82%           
=======================================
  Files         119      119           
  Lines        6322     6322           
  Branches      301      301           
=======================================
  Hits         6311     6311           
  Misses         10       10           
  Partials        1        1           

@sarahgm sarahgm requested a review from sebald January 17, 2024 10:07
@sebald sebald merged commit 139190e into main Jan 18, 2024
14 checks passed
@sebald sebald deleted the add-onchange-description-in-docs branch January 18, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants