Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DST-367]: rac SelectList component #3708

Merged
merged 37 commits into from
Apr 8, 2024
Merged

[DST-367]: rac SelectList component #3708

merged 37 commits into from
Apr 8, 2024

Conversation

aromko
Copy link
Contributor

@aromko aromko commented Feb 8, 2024

In order to solve the multiselect issue from TCO it could be a possible solution to use the gridlist from react-aria. It's similiar to a listbox but offers some other stuf, like action button which is maybe useful in future.

Copy link

changeset-bot bot commented Feb 8, 2024

🦋 Changeset detected

Latest commit: bf7b88a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@marigold/components Minor
@marigold/docs Minor
@marigold/storybook-config Patch
@marigold/theme-b2b Patch
@marigold/theme-core Patch
@marigold/system Minor
@marigold/icons Patch
@marigold/theme-preset Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marigold-docs ✅ Ready (Inspect) Visit Preview 1 resolved Apr 8, 2024 1:44pm
marigold-storybook ✅ Ready (Inspect) Visit Preview 3 resolved Apr 8, 2024 1:44pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
marigold-production ⬜️ Ignored (Inspect) Visit Preview Apr 8, 2024 1:44pm

@github-actions github-actions bot added the type:feature New feature or component label Feb 8, 2024
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.59%. Comparing base (c25da22) to head (d28a9ab).
Report is 1 commits behind head on main.

❗ Current head d28a9ab differs from pull request most recent head bf7b88a. Consider uploading reports for the commit bf7b88a to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3708      +/-   ##
==========================================
- Coverage   99.63%   99.59%   -0.04%     
==========================================
  Files         122      125       +3     
  Lines        6557     6670     +113     
  Branches      322      323       +1     
==========================================
+ Hits         6533     6643     +110     
- Misses         23       26       +3     
  Partials        1        1              
Files Coverage Δ
packages/components/src/SelectList/Context.ts 100.00% <100.00%> (ø)
packages/components/src/SelectList/SelectList.tsx 100.00% <100.00%> (ø)
...kages/components/src/SelectList/SelectListItem.tsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@sarahgm
Copy link
Member

sarahgm commented Feb 23, 2024

@aromko is this still a draft?

@aromko
Copy link
Contributor Author

aromko commented Feb 23, 2024

@aromko is this still a draft?

@sarahgm Yes. It's just the first try from our mob. We can decide in our next cycle when we continue with that or feel free to go on 😄

@aromko
Copy link
Contributor Author

aromko commented Apr 8, 2024

@OsamaAbdellateef Can't approve because I'm the creator of the PR. But it's fine for me now.

@OsamaAbdellateef
Copy link
Contributor

@OsamaAbdellateef Can't approve because I'm the creator of the PR. But it's fine for me now.
Then @sebald or @sarahgm can merge 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:docs Improvements or additions to documentation type:feature New feature or component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants