Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs([DST-586]): remove examples from checkbox page and add guidline section #4207

Merged
merged 9 commits into from
Oct 16, 2024

Conversation

sebald
Copy link
Member

@sebald sebald commented Oct 11, 2024

Description

  • Removed the examples section
  • added guidline about the difference between a checkbox and a switch
  • site clean up

Reviewers:

@marigold-ui/developer
@marigold-ui/designer

Issue

Ref DST-586

Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marigold-docs ✅ Ready (Inspect) Visit Preview 3 resolved Oct 16, 2024 7:21am
marigold-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 7:21am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
marigold-production ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 7:21am

Copy link

changeset-bot bot commented Oct 11, 2024

🦋 Changeset detected

Latest commit: 922df97

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@marigold/docs Patch
@marigold/system Patch
@marigold/components Patch
@marigold/icons Patch
@marigold/theme-preset Patch
@marigold/theme-b2b Patch
@marigold/theme-core Patch
@marigold/theme-docs Patch
@marigold/storybook-config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the type:docs Improvements or additions to documentation label Oct 11, 2024
Copy link
Contributor

github-actions bot commented Oct 11, 2024

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
99.24% (+0.04% 🔼)
7940/8001
🟢 Branches
90.25% (+0.02% 🔼)
361/400
🟢 Functions 98.48% 130/132
🟢 Lines
99.24% (+0.04% 🔼)
7940/8001
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / Button.tsx
100%
50% (-50% 🔻)
100% 100%
🟢
... / Checkbox.tsx
98.48% (-1.52% 🔻)
91.67% (+7.05% 🔼)
100%
98.48% (-1.52% 🔻)
🟢
... / Headline.tsx
100%
50% (-50% 🔻)
100% 100%
🟢
... / HelpText.tsx
97.83% (-2.17% 🔻)
76.92% (-23.08% 🔻)
100%
97.83% (-2.17% 🔻)

Test suite run success

575 tests passing in 78 suites.

Report generated by 🧪jest coverage report action from 922df97

@sarahgm
Copy link
Member

sarahgm commented Oct 14, 2024

The Title should contain the issue number :)

@sebald sebald requested a review from sarahgm October 16, 2024 07:17
@sarahgm sarahgm changed the title docs: remove examples from checkbox page and add guidline section docs([DST-586]): remove examples from checkbox page and add guidline section Oct 16, 2024
@sarahgm sarahgm merged commit e83566d into main Oct 16, 2024
15 checks passed
@sarahgm sarahgm deleted the revise-checkbox branch October 16, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants