Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Revise Dialog #4229

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

docs: Revise Dialog #4229

wants to merge 2 commits into from

Conversation

sebald
Copy link
Member

@sebald sebald commented Oct 21, 2024

Description

Please include a summary of the change and which issue is fixed when no corresponding ticket is available. Add additional informations the reviewers should know.

  • [] This change requires a UI-Kit update - inform Alex Tirado (@tirado-rx)

What should be tested?

Are they some special informations required to test something?

Reviewers:

Which persons should review this PR? Add person with @mentions

Examples:
@marigold-ui/developer
@marigold-ui/designer

Copy link

changeset-bot bot commented Oct 21, 2024

⚠️ No Changeset found

Latest commit: de74699

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marigold-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 11:57am
marigold-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 11:57am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
marigold-production ⬜️ Ignored (Inspect) Visit Preview Oct 22, 2024 11:57am

@github-actions github-actions bot added type:docs Improvements or additions to documentation type:feature New feature or component labels Oct 21, 2024
Copy link
Contributor

github-actions bot commented Oct 21, 2024

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
99.27% (+0.15% 🔼)
7986/8045
🟢 Branches
89.42% (+1.04% 🔼)
355/397
🟢 Functions
98.45% (-0.05% 🔻)
127/129
🟢 Lines
99.27% (+0.15% 🔼)
7986/8045
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / DialogActions.tsx
100% 100% 100% 100%
🟢
... / DialogContent.tsx
100% 100% 100% 100%
🟢
... / DialogFooter.tsx
100% 100% 100% 100%
🟢
... / DialogTitle.tsx
100% 100% 100% 100%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / Dialog.tsx
100%
75% (-12.5% 🔻)
66.67% (-19.05% 🔻)
100%
🟢
... / Headline.tsx
100%
50% (-50% 🔻)
100% 100%
🟢
... / Input.tsx
98.72% (-1.28% 🔻)
80% (-20% 🔻)
100%
98.72% (-1.28% 🔻)

Test suite run success

576 tests passing in 78 suites.

Report generated by 🧪jest coverage report action from de74699

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:docs Improvements or additions to documentation type:feature New feature or component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant