Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix([DSTSUP-92]): fix broken variants in table stories #4230

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aromko
Copy link
Contributor

@aromko aromko commented Oct 22, 2024

Description

The Controls are not working in the Nested Columns-Variant of the Table in Storybook.
args was missing in certain stories.

What should be tested?

Have a look at all table stories. Variants should work now.

Reviewers:

@marigold-ui/developer
@KadaStrophe

Copy link

changeset-bot bot commented Oct 22, 2024

🦋 Changeset detected

Latest commit: 208f18f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@marigold/components Patch
@marigold/storybook-config Patch
@marigold/docs Patch
@marigold/theme-b2b Patch
@marigold/theme-core Patch
@marigold/theme-docs Patch
@marigold/system Patch
@marigold/icons Patch
@marigold/theme-preset Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marigold-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 6:25am
marigold-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 6:25am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
marigold-production ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 6:25am

@github-actions github-actions bot added the type:feature New feature or component label Oct 22, 2024
@aromko aromko changed the title DSTSUP-92: fix broken variants in table stories bugfix([DSTSUP-92]): fix broken variants in table stories Oct 22, 2024
Copy link
Contributor

github-actions bot commented Oct 22, 2024

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
99.27% (+0.22% 🔼)
7988/8047
🟢 Branches
89.78% (+0.55% 🔼)
360/401
🟢 Functions 98.5% 131/133
🟢 Lines
99.27% (+0.22% 🔼)
7988/8047
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / HelpText.tsx
97.83% (-2.17% 🔻)
76.92% (-23.08% 🔻)
100%
97.83% (-2.17% 🔻)
🟢
... / Text.tsx
100%
14.29% (-14.29% 🔻)
100% 100%

Test suite run success

576 tests passing in 78 suites.

Report generated by 🧪jest coverage report action from 208f18f

Copy link
Collaborator

@KadaStrophe KadaStrophe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature or component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants