-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added some content #6
base: master
Are you sure you want to change the base?
Conversation
I may have mistaken the meaning of implementors... |
<!DOCTYPE html> | ||
<html> | ||
<head> | ||
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This had a valid html5 doctype. Why should we change this? I see no reason. Both html and xhtml are valid under html5.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for sticking with <!DOCTYPE html>
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok my bad.
The favicon is nice, but if it comes from Github, do we have permission to use it? I didn't check, maybe it's licenced in an acceptable manner. But I think we should verify that before using it. |
I created the icon, so I think we're okay. ;) |
Dammit why didn't I use topic branches! |
Unless you guys have a way to pick and choose commits to add, or can do a manual merge/edit/commit/push then reject this pull request and I will submit more coherent content and topic branches. |
Added some implementations, developers and added another section for libraries that parse markdown.
I also added a favicon (the same as the markdown github repo avatar).
Tested it in jekyll all looks good.