Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return type issue for php8.1 #370

Closed
wants to merge 2 commits into from

Conversation

saysource
Copy link

Without setting the return type in the exceptions, I get the error already logged here:

#369

Hope this helps, it is a really simple fix.

@webignition
Copy link
Contributor

This is a subset of the changes in PR #366.

Perhaps this should be closed in preference to merging #366 as that also includes additional SF7 compatibility changes.

@saysource
Copy link
Author

Yep, closing.

@saysource saysource closed this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants