Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fork #244

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

feat: add fork #244

wants to merge 5 commits into from

Conversation

ppeeou
Copy link
Member

@ppeeou ppeeou commented Feb 12, 2024

Fixes #70

@darky I'd like to get feedback from you
What do you think about the expression and behavior?

  • sync
  • async
  • concurrent
  • error propagation

@ppeeou ppeeou requested a review from hg-pyun February 12, 2024 07:22
@ppeeou ppeeou self-assigned this Feb 12, 2024
@ppeeou ppeeou requested a review from shine1594 as a code owner February 12, 2024 07:22
@darky
Copy link
Contributor

darky commented Feb 13, 2024

@ppeeou
Great, thanks!

src/Lazy/fork.ts Outdated Show resolved Hide resolved
src/Lazy/fork.ts Show resolved Hide resolved
Copy link
Collaborator

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it okay? concurrent, error propagation not yet.

@ppeeou ppeeou marked this pull request as draft March 11, 2024 14:41
@ppeeou
Copy link
Member Author

ppeeou commented Mar 11, 2024

@hg-pyun Since all the checkboxes have not been completed yet, I changed it to draft !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add fork function
3 participants