Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bootswatch theme name typo morth -> morph #1174

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Fix bootswatch theme name typo morth -> morph #1174

merged 1 commit into from
Dec 12, 2024

Conversation

r1gm
Copy link
Contributor

@r1gm r1gm commented Dec 12, 2024

No description provided.

@solomax
Copy link
Contributor

solomax commented Dec 12, 2024

Hello @r1gm
These themes are being updated via script
Would this script work after your changes? :)

@r1gm
Copy link
Contributor Author

r1gm commented Dec 12, 2024

i download the morph one from the script(i run the script in Windows WSL Ubuntu, i don't have real Linux)

@solomax
Copy link
Contributor

solomax commented Dec 12, 2024

Great, thanks for checking :)

martin-g
martin-g approved these changes Dec 12, 2024
View reviewed changes
...s/src/main/java/de/agilecoders/wicket/themes/markup/html/bootswatch/css/bootstrap.morth.scss
@@ -1,4 +0,0 @@
@import "../../bootstrap/css/bootstrap.scss";
@import "bootstrap.morth.variables.scss";
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how it worked until now ?!
The old / wrongly named file has some contents ...

It has been added at 2021 with bb7068d#diff-683cc9e10b8f8a68e6ca651d4a8471ca5f992de071eccea96a257ba40a9cf206
and I see no related issue/PR for renaming from morth to morph at https://github.com/thomaspark/bootswatch/issues?q=is%3Aissue+morph+is%3Aclosed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I did some sort of manual steps with typo ...
I can't remember now :(

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The contents is actually added by gettheme.sh itself ...

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've improved the Shell script to fail early with 6c54b09

@martin-g martin-g merged commit 3dcdded into martin-g:wicket-10.x-bootstrap-5.x Dec 12, 2024
2 checks passed
@martin-g
Copy link
Owner

Thank you, @r1gm !

martin-g pushed a commit that referenced this pull request Dec 12, 2024
@r1gm @martin-g
fix theme name typo morth -> morph (#1174)
a92ad39 
(cherry picked from commit 3dcdded)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solomax solomax solomax left review comments

@martin-g martin-g martin-g approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@r1gm @solomax @martin-g