Skip to content

another shot at fixing mdbook deploy (#469) #4

another shot at fixing mdbook deploy (#469)

another shot at fixing mdbook deploy (#469) #4

Triggered via push September 17, 2024 03:57
Status Skipped
Total duration 4s
Artifacts

mdbook.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

19 warnings
this expression creates a reference which is immediately dereferenced by the compiler: app/src/commands/apply.rs#L81
warning: this expression creates a reference which is immediately dereferenced by the compiler --> app/src/commands/apply.rs:81:48 | 81 | let manifest_path = self.manifest_path(&runtime)?; | ^^^^^^^^ help: change this to: `runtime` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
useless use of `format!`: app/src/commands/apply.rs#L68
warning: useless use of `format!` --> app/src/commands/apply.rs:68:27 | 68 | Cell::new(format!("{name}")), | ^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `name.to_string()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format = note: `#[warn(clippy::useless_format)]` on by default
this expression creates a reference which is immediately dereferenced by the compiler: app/src/commands/apply.rs#L54
warning: this expression creates a reference which is immediately dereferenced by the compiler --> app/src/commands/apply.rs:54:48 | 54 | let manifest_path = self.manifest_path(&runtime)?; | ^^^^^^^^ help: change this to: `runtime` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
this expression creates a reference which is immediately dereferenced by the compiler: app/src/commands/apply.rs#L81
warning: this expression creates a reference which is immediately dereferenced by the compiler --> app/src/commands/apply.rs:81:48 | 81 | let manifest_path = self.manifest_path(&runtime)?; | ^^^^^^^^ help: change this to: `runtime` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
useless use of `format!`: app/src/commands/apply.rs#L68
warning: useless use of `format!` --> app/src/commands/apply.rs:68:27 | 68 | Cell::new(format!("{name}")), | ^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `name.to_string()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format = note: `#[warn(clippy::useless_format)]` on by default
this expression creates a reference which is immediately dereferenced by the compiler: app/src/commands/apply.rs#L54
warning: this expression creates a reference which is immediately dereferenced by the compiler --> app/src/commands/apply.rs:54:48 | 54 | let manifest_path = self.manifest_path(&runtime)?; | ^^^^^^^^ help: change this to: `runtime` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)`: lib/src/atoms/command/exec.rs#L110
warning: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)` --> lib/src/atoms/command/exec.rs:110:23 | 110 | let command = utilities::get_binary_path(&command) | _______________________^ 111 | | .or_else(|_| Err(anyhow!("Command `{}` not found in path", command)))?; | |_________________________________________________________________________________^ help: try: `utilities::get_binary_path(&command).map_err(|_| anyhow!("Command `{}` not found in path", command))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map = note: `#[warn(clippy::bind_instead_of_map)]` on by default
using `clone` on type `bool` which implements the `Copy` trait: lib/src/actions/package/mod.rs#L94
warning: using `clone` on type `bool` which implements the `Copy` trait --> lib/src/actions/package/mod.rs:94:19 | 94 | file: package.file.clone(), | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `package.file` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
using `clone` on type `bool` which implements the `Copy` trait: lib/src/actions/package/mod.rs#L80
warning: using `clone` on type `bool` which implements the `Copy` trait --> lib/src/actions/package/mod.rs:80:23 | 80 | file: package.file.clone(), | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `package.file` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `#[warn(clippy::clone_on_copy)]` on by default
using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)`: lib/src/atoms/command/exec.rs#L110
warning: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)` --> lib/src/atoms/command/exec.rs:110:23 | 110 | let command = utilities::get_binary_path(&command) | _______________________^ 111 | | .or_else(|_| Err(anyhow!("Command `{}` not found in path", command)))?; | |_________________________________________________________________________________^ help: try: `utilities::get_binary_path(&command).map_err(|_| anyhow!("Command `{}` not found in path", command))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map = note: `#[warn(clippy::bind_instead_of_map)]` on by default
`assert!(false)` should probably be replaced: lib/src/actions/package/providers/aptitude.rs#L221
warning: `assert!(false)` should probably be replaced --> lib/src/actions/package/providers/aptitude.rs:221:13 | 221 | assert!(false); | ^^^^^^^^^^^^^^ | = help: use `panic!()` or `unreachable!()` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants = note: `#[warn(clippy::assertions_on_constants)]` on by default
useless use of `format!`: lib/src/actions/package/install.rs#L17
warning: useless use of `format!` --> lib/src/actions/package/install.rs:17:9 | 17 | format!("Installing packages") | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Installing packages".to_string()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format = note: `#[warn(clippy::useless_format)]` on by default
using `clone` on type `bool` which implements the `Copy` trait: lib/src/actions/package/mod.rs#L94
warning: using `clone` on type `bool` which implements the `Copy` trait --> lib/src/actions/package/mod.rs:94:19 | 94 | file: package.file.clone(), | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `package.file` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
using `clone` on type `bool` which implements the `Copy` trait: lib/src/actions/package/mod.rs#L80
warning: using `clone` on type `bool` which implements the `Copy` trait --> lib/src/actions/package/mod.rs:80:23 | 80 | file: package.file.clone(), | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `package.file` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `#[warn(clippy::clone_on_copy)]` on by default
single-character string constant used as pattern: lib/src/actions/directory/copy.rs#L49
warning: single-character string constant used as pattern --> lib/src/actions/directory/copy.rs:49:30 | 49 | if self.to.ends_with("/") { | ^^^ help: consider using a `char`: `'/'` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern = note: `#[warn(clippy::single_char_pattern)]` on by default
useless use of `format!`: lib/src/actions/package/install.rs#L17
warning: useless use of `format!` --> lib/src/actions/package/install.rs:17:9 | 17 | format!("Installing packages") | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Installing packages".to_string()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format = note: `#[warn(clippy::useless_format)]` on by default
single-character string constant used as pattern: lib/src/actions/directory/copy.rs#L49
warning: single-character string constant used as pattern --> lib/src/actions/directory/copy.rs:49:30 | 49 | if self.to.ends_with("/") { | ^^^ help: consider using a `char`: `'/'` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern = note: `#[warn(clippy::single_char_pattern)]` on by default
this import is redundant: lib/src/utilities/mod.rs#L1
warning: this import is redundant --> lib/src/utilities/mod.rs:1:1 | 1 | use which; | ^^^^^^^^^^ help: remove it entirely | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports = note: `#[warn(clippy::single_component_path_imports)]` on by default
this import is redundant: lib/src/utilities/mod.rs#L1
warning: this import is redundant --> lib/src/utilities/mod.rs:1:1 | 1 | use which; | ^^^^^^^^^^ help: remove it entirely | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports = note: `#[warn(clippy::single_component_path_imports)]` on by default