Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port the project to meson #185

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Port the project to meson #185

merged 2 commits into from
Jan 21, 2025

Conversation

aruiz
Copy link

@aruiz aruiz commented Jan 12, 2025

In order to make the project a bit more maintainable, I have ported its build system to meson.

@masneyb masneyb merged commit 39532ad into masneyb:master Jan 21, 2025
@masneyb
Copy link
Owner

masneyb commented Jan 21, 2025

Thanks @aruiz for the contribution.

There are lots of warnings that need to be cleaned up, and most are related to ununsed parameters. Most can be silenced with:

diff --git a/meson.build b/meson.build
index fa71f0de36fe..184e7d3720aa 100644
--- a/meson.build
+++ b/meson.build
@@ -18,6 +18,8 @@ project_version = meson.project_version()
 project_name = meson.project_name()
 
 add_project_arguments(f'-DPACKAGE_NAME="@project_name@"', language:'c')
+add_project_arguments('-Wno-unused-parameter', language:'c')
+add_project_arguments('-Wno-cpp', language:'c')
 
 cc = meson.get_compiler('c')
 pthread = cc.find_library('pthread', required: true)

I don't want to apply this to the project, however I did it in my branch just to see if there are other warnings that need to be addessed. I see a few that I'll push up a branch with some fixes.

@masneyb
Copy link
Owner

masneyb commented Jan 21, 2025

I updated the README to use meson with this commit: c4d8f09

I fixed some warnings with this commit: 7c256a3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants