Deferred_calls #335
Draft
Deferred_calls #335
+727
−318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .get_interface() | ||
| .deferred_call_quote(asc_slot, max_gas as u64)?; | ||
| if !available { | ||
| price = 0; |
There was a problem hiding this comment.
If !available, why don't we abi_bail!() instead?
There was a problem hiding this comment.
because it's a quote, not a reservation attempt
damip
reviewed
Aug 18, 2024
Cargo.toml
Outdated
| @@ -11,6 +11,7 @@ chrono = { version = "=0.4", features = ["clock"], default-features = false } | |||
| displaydoc = "0.2" | |||
| function_name = "0.3" | |||
| loupe = "0.1" | |||
| #massa-proto-rs = { git = "https://github.com/massalabs/massa-proto-rs.git", rev = "426fd325a55dfcc4033920bed2de075a7e7ad4b7" } | |||
There was a problem hiding this comment.
update of massa-proto-rs :
damip
reviewed
Aug 18, 2024
src/as_execution/abi.rs
Outdated
| (Err(_), _) => abi_bail!("negative validity end period"), | ||
| (_, Err(_)) => abi_bail!("invalid validity end thread"), | ||
| }; | ||
| if max_gas.is_negative() { |
There was a problem hiding this comment.
best practice: better do a try_into u64 directly since below we convert using "as u64"
damip
reviewed
Aug 18, 2024
src/as_execution/abi.rs
Outdated
| (Err(_), _) => abi_bail!("negative validity end period"), | ||
| (_, Err(_)) => abi_bail!("invalid validity end thread"), | ||
| }; | ||
| if max_gas.is_negative() { |
damip
reviewed
Aug 18, 2024
src/as_execution/abi.rs
Outdated
| if max_gas.is_negative() { | ||
| abi_bail!("negative max gas"); | ||
| } | ||
| if raw_coins.is_negative() { |
damip
reviewed
Aug 18, 2024
Comment on lines
+274
to
+277
| abi_costs.insert(String::from("assembly_script_get_deferred_call_quote"), 11); | ||
| abi_costs.insert(String::from("assembly_script_deferred_call_register"), 11); | ||
| abi_costs.insert(String::from("assembly_script_deferred_call_exists"), 11); | ||
| abi_costs.insert(String::from("assembly_script_deferred_call_cancel"), 11); |
damip
requested changes
Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.