Feature/multisig sc #120
Open
Feature/multisig sc #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…el it (this avoids attacks from hostile/compromised owners to cancel-bomb any pending operation)
…into "delete". Owners can delete eecuted operations and creator can delete at any time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a multisig contract to Massa Standard.
Inspired by: https://solidity-by-example.org/app/multi-sig-wallet
Add a MultisigWrapper class to hide the serialization/deserialization
Add multisig.spec.ts for as-spec tests.
Key features:
=> deposit funds on the contract (anybody can do this)
=> submit transaction or call operation (only owners can do this)
=> each owner can confirm pending operations (or revoke its previous confirmation if the operation is not yet executed)
=> the creator of the operation can delete the operation at any given time
=> once enough confirmations are received, the operation can be executed (only owners can do this)
=> executed operations are kept for archive purposes. Any owner can delete an executed operation.
Transactions are stored in a map in Storage even after they have been executed. Whoever has created the operation can delete it even if it is not yet executed. If the operation is already executed, any owner can delete it. Executed operations can only be deleted, they cannot be modified anymore (in particular no further confirmation/revocation is possible, in order to keep the archive truthful).
Possible improvement: add a timeout to pending operations and an automatic garbage collector for old executed operations.