Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional OTEL options #152

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Add additional OTEL options #152

merged 3 commits into from
Sep 30, 2024

Conversation

timetinytim
Copy link
Contributor

No description provided.

@timetinytim timetinytim requested a review from renchap September 26, 2024 13:33
@timetinytim timetinytim self-assigned this Sep 26, 2024
values.yaml Outdated
@@ -413,6 +415,7 @@ mastodon:
enabled: false
exporterUri:
namePrefix: mastodon
nameSeparator: /
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this one different from the others above?

Also, if we set a default, shouldnt it be something that is k8s-compliant in the chart?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah that's a good point...I made the default / because that's what it is in the code, but I agree, it doesn't make sense to keep it that when it's not good for k8s. I'll make it - by default.

Though I apologize, I'm not sure what you mean "why is it different"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On lines 188 and 388 you do not set this value

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh I understand
Because these are the global values. lines 188 and 388 are deployment-specific, and will assume the global values if not set (coalesce).

@timetinytim timetinytim merged commit 29a3645 into main Sep 30, 2024
8 checks passed
@timetinytim timetinytim deleted the add-otel-options branch September 30, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants