-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add puma metrics for web and sidekiq pods #170
base: main
Are you sure you want to change the base?
Conversation
…pods because of sidecar, 0.0.0.0 for sidekiq
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I am not sure about the requests/limits, I suspect the CPU will be very low here, so maybe having a request does not make sense. For the memory, it will need to be adjusted depending on real usage.
@renchap I suspect the CPU usage will be incredibly low as well, I just want to make sure that things like sidecars are somewhat predictable. And yeah, the memory was my best guess based on what I saw in testing, but we can modify that over time if necessary |
Adds environment variables to both web and sidekiq pods to optionally enable Puma metrics. Additionally adds a sidecar to the web pods to collect all metrics from all processes, as puma is multi-process.