Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add puma metrics for web and sidekiq pods #170

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

timetinytim
Copy link
Contributor

Adds environment variables to both web and sidekiq pods to optionally enable Puma metrics. Additionally adds a sidecar to the web pods to collect all metrics from all processes, as puma is multi-process.

@timetinytim timetinytim requested a review from renchap March 4, 2025 16:01
@timetinytim timetinytim self-assigned this Mar 4, 2025
Copy link
Member

@renchap renchap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I am not sure about the requests/limits, I suspect the CPU will be very low here, so maybe having a request does not make sense. For the memory, it will need to be adjusted depending on real usage.

@timetinytim
Copy link
Contributor Author

@renchap I suspect the CPU usage will be incredibly low as well, I just want to make sure that things like sidecars are somewhat predictable. And yeah, the memory was my best guess based on what I saw in testing, but we can modify that over time if necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants