Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable supplementary environment variables. #69

Merged
merged 3 commits into from
Feb 16, 2024

Conversation

cerebrate
Copy link
Contributor

Not all Mastodon configuration options are currently exposed by the Helm chart. Additionally, while it obviously isn't the job of this chart to support all the varietals of Mastodon (Glitch Edition, etc.) out there, it is convenient to be able to use it with them, and they tend to expose additional configuration options/environment variables.

This PR adds a mechanism by which additional configuration options/environment variables can be defined in a supplementary ConfigMap, and then added to the Mastodon pods using a simple addition to the values.yaml, e.g.:

---
apiVersion: v1
kind: ConfigMap
metadata:
  name: mastodon-supplementary
data:
  ADDITIONAL_OPTION: "value"

and

mastodon:

  extraEnvironment: mastodon-supplementary

@timetinytim
Copy link
Contributor

Sorry for the long delay in looking at this! This poor chart has been neglected for far too long, and I'm now finally going through all the PRs and suggestions!

@timetinytim timetinytim self-assigned this Dec 7, 2023
@dunn
Copy link
Contributor

dunn commented Feb 15, 2024

maintenance of this repo appears to be abandoned, so unless one of us can get push permissions this probably won't go through, but all the same i would suggest using instead extraEnvVars and extraEnvFrom which are commonly used to allow providing arbitrary values directly or via an external configmap, respectively.

@timetinytim
Copy link
Contributor

Apologies for the lack of activity! I've been working on infrastructure-related stuff a lot lately and recently have more time to go through these requests.

This is good call, especially since it's a common pattern. I'll take care of this right now.

@timetinytim timetinytim merged commit 84f04ad into mastodon:main Feb 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants