[cypress-tools]: cypress plugin snapshot added #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuriiHoliuk
requested changes
Apr 20, 2022
cypress-tools/support/commands.js
Outdated
| Cypress.Commands.add('getByDataCy', (selector) => { | ||
| cy.get(`[data-cy="${selector}"]`); | ||
| }); | ||
|
|
||
| addMatchImageSnapshotCommand({ | ||
| failureThreshold: 3.0, |
There was a problem hiding this comment.
я б не робив такого. Це не допоможе з flaky, але зробить тести ненадійними
mate-scripts/package.json
Outdated
| @@ -61,6 +61,7 @@ | |||
| "@types/jest": "^26.0.20", | |||
| "@types/node": "^14.14.35", | |||
| "@types/sinon": "^9.0.10", | |||
| "cypress-image-snapshot": "^4.0.1", | |||
There was a problem hiding this comment.
no, you should add it to cypress-tools
iBrianWarner
force-pushed
the
add_img_snapshot_cypress
branch
from
6258b6c to
376b88f
Compare
YuriiHoliuk
approved these changes
Apr 26, 2022
| @@ -1,5046 +1,9 @@ | |||
| { | |||
| "name": "@mate-academy/cypress-tools", | |||
| "version": "1.0.3", | |||
| "lockfileVersion": 2, | |||
There was a problem hiding this comment.
чому пропав весь контент файлу?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.