Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task solution #1420

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

task solution #1420

wants to merge 2 commits into from

Conversation

OlhaLishenko
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your solution is almost there! 🎯 However, there's a critical requirement that needs addressing: each label element should have its for attribute set to the id of the corresponding input. This is essential for accessibility and functionality. Once you make this adjustment, your code will meet all the task requirements. Keep up the great work, and feel free to reach out if you need any help! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on addressing the previous feedback! 🎉 Your code now correctly sets the for attribute of label elements to match the id of their corresponding input, enhancing accessibility. The solution meets all task requirements by retrieving input elements, setting placeholders, creating and inserting label elements, and adhering to constraints by only modifying main.js. There are no missing or unrelated files, and the task requirements are fully satisfied. Keep up the good work and continue improving your skills! If there are any issues, make sure to review the comments to enhance your code further.

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants