Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solve task #1421

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

solve task #1421

wants to merge 1 commit into from

Conversation

Kredinec
Copy link

mateacademy-ai-mentor
mateacademy-ai-mentor approved these changes Jan 30, 2025
View reviewed changes
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the task requirements! 🎉 Your code dynamically creates and inserts labels for form inputs effectively. Just make sure each input element has a unique id attribute to ensure proper label association. Keep up the good work and happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

src/scripts/main.js
const label = document.createElement('label');

label.classList.add('field-label');
label.setAttribute('for', input.id);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that each input element has a unique id attribute. The for attribute of the label should match the id of the input to correctly associate the label with the input element. If any input lacks an id, this could lead to incorrect behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateacademy-ai-mentor mateacademy-ai-mentor mateacademy-ai-mentor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kredinec @mateacademy-ai-mentor