Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

done #1425

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

done #1425

wants to merge 2 commits into from

Conversation

kasianeno
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the task requirements! 🎉 Your code is well-structured and meets all the core requirements, including adding labels and placeholders correctly. While there's a minor suggestion to improve variable naming for better readability, it doesn't impact the functionality. Keep up the good work and consider using camelCase for variable names in the future to align with common JavaScript conventions. 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

const inputs = document.querySelectorAll('form input');

inputs.forEach(((input) => {
const parentelement = input.parentElement;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using camelCase for variable names in JavaScript to improve readability and follow common conventions. You could rename parentelement to parentElement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants