done #1435
done #1435
Conversation
There was a problem hiding this comment.
Your code meets all the task requirements and constraints effectively! 🎉 While there are some suggestions for improving readability and preventing potential errors, such as checking if parented is not null before calling prepend, using a for...of loop, and considering Array.from() for converting NodeList to an array, these are minor improvements. They don't impact the core functionality of your solution. Keep up the great work, and consider these suggestions for future projects to enhance your code quality even further! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| @@ -1,3 +1,28 @@ | |||
| 'use strict'; | |||
|
|
|||
| // write code here | |||
| const inputsCollection = [...document.querySelectorAll('input')]; | |||
There was a problem hiding this comment.
Consider using Array.from() instead of the spread operator for converting NodeList to an array. It is more explicit and can be more readable.
| // write code here | ||
| const inputsCollection = [...document.querySelectorAll('input')]; | ||
|
|
||
| for (let i = 0; i < inputsCollection.length; i++) { |
There was a problem hiding this comment.
Using a for...of loop instead of a traditional for loop can make the code more readable when iterating over arrays.
|
|
||
| label.textContent = currentValue.toUpperCase(); | ||
|
|
||
| const parented = inputsCollection[i].parentElement; |
There was a problem hiding this comment.
Consider checking if parented is not null before calling prepend. This will prevent potential errors if an input element does not have a parent element.
No description provided.