Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add task solution #1460

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add task solution #1460

wants to merge 1 commit into from

Conversation

VasilPan
Copy link 

- [DEMO LINK](https://VasilPan.github.io/js_task_fix_form_DOM/)

mateacademy-ai-mentor
mateacademy-ai-mentor approved these changes Feb 24, 2025
View reviewed changes
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the task requirements! 🎉 The code functions as intended, and you've done well to meet all the specified constraints. Just a small note: there's a minor typo in the variable name creatElement, which should be corrected to createElement to prevent any confusion in the future. Keep up the great work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

src/scripts/main.js
const allInputs = document.querySelectorAll('input');

for (const el of allInputs) {
const creatElement = document.createElement('label');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in the variable name creatElement. It should be createElement to accurately reflect its purpose and avoid confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateacademy-ai-mentor mateacademy-ai-mentor mateacademy-ai-mentor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VasilPan @mateacademy-ai-mentor