Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add task solution #1466

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add task solution #1466

wants to merge 2 commits into from

Conversation

SofiiaPelenska
Copy link

mateacademy-ai-mentor
mateacademy-ai-mentor approved these changes Feb 28, 2025
View reviewed changes
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the task requirements! 🎉 Your code correctly creates labels for input elements and sets their placeholders. Just make sure each input element has a unique id attribute to ensure the labels are properly associated. Keep up the fantastic work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

src/scripts/main.js Outdated
const label = document.createElement('label');

label.classList.add('field-label');
label.setAttribute('for', inputElement.id);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that each input element has a unique 'id' attribute. The 'for' attribute of the label is set using the input element's 'id', so if any input lacks an 'id', the label will not be correctly associated with the input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateacademy-ai-mentor mateacademy-ai-mentor mateacademy-ai-mentor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SofiiaPelenska @mateacademy-ai-mentor