Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #1475

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ievgen-nikiforov
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the task! 🎉 Your code meets all the requirements and constraints outlined in the task description. While the order of labels and input fields might need a slight adjustment to ensure labels appear before inputs, your solution is functional and well-structured. Keep up the good work, and consider the suggestion for future improvements. 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

label.setAttribute('class', 'field-label');
label.setAttribute('for', li.id);
label.textContent = labelName;
li.parentNode.append(label, li);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appending the label and input field in this order might result in the label appearing after the input field. If the intention is to have the label appear before the input field, consider using li.parentNode.insertBefore(label, li); instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants