Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1476

Closed
wants to merge 2 commits into from
Closed

Solution #1476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf5b2c4
Solution
IvanVaniuk Mar 4, 2025
b1af51a
Solution2
IvanVaniuk Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
1. Replace `<your_account>` with your Github username in the link
- [DEMO LINK](https://<your_account>.github.io/js_task_fix_form_DOM/)
- [DEMO LINK](https://IvanVaniuk.github.io/js_task_fix_form_DOM/)
2. Follow [this instructions](https://mate-academy.github.io/layout_task-guideline/)
- Run `npm run test` command to test your code;
- Run `npm run test:only -- -n` to run fast test ignoring linter;
Expand Down
16 changes: 16 additions & 0 deletions src/scripts/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@
'use strict';

// write code here
const inputs = document.querySelectorAll('input');

inputs.forEach(input => {
const label = document.createElement('label');
label.classList.add('field-label');

if(!input.id) {
input.id = input.name;
Comment on lines +10 to +11
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This block assigns an ID to inputs that do not have one, using the input's name. Ensure that input names are unique to avoid duplicate IDs, which can cause issues in the DOM.

}

label.setAttribute('for', input.id);
label.textContent = input.name.charAt(0).toUpperCase() + input.name.slice(1);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The label's text content is set by capitalizing the first letter of the input's name. Ensure that input names are descriptive and user-friendly, as they will be displayed as labels.

input.placeholder = label.textContent;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The placeholder is set to the same value as the label's text content. Consider whether this is the desired behavior, as placeholders typically provide additional guidance or examples for the user.


input.parentNode.insertBefore(label, input);
});
Loading