Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taskFIX #1481

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

taskFIX #1481

wants to merge 1 commit into from

Conversation

IOherhi
Copy link

@IOherhi IOherhi commented Mar 5, 2025

- [DEMO LINK](https://IOherhi.github.io/js_task_fix_form_DOM/)

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Thank you for your effort on this task! 😊 However, there are a few critical issues that need to be addressed before we can approve the pull request:

  1. Syntax Error: There's a syntax error on line 6 due to the incorrect declaration of the variable fielD. This prevents the script from running. Please correct it to const field = body.querySelectorAll('.field');.

  2. Missing <label> Elements: The task requires creating and appending <label> elements for each input with the class field-label and the for attribute set to the id of the current input. This logic is missing from your code.

  3. Placeholder Capitalization: While you correctly set the placeholder attribute, the capitalization is not as specified. Instead of using toUpperCase(), you should capitalize only the first letter of the name.

  4. Appending Labels: The created <label> elements should be appended to the parent container of each input, which is currently not implemented.

Please address these issues to meet the core requirements of the task. Once these changes are made, your solution will be much closer to completion. Keep up the good work, and don't hesitate to reach out if you need further assistance! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

const body = document.body;
const allInputs = body.querySelectorAll('input')
const arrayInputs = [...allInputs];
const fielD body.querySelectorAll('.field');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a syntax error here. The variable fielD is not correctly declared. It seems like you intended to declare a constant for elements with the class 'field'. You should correct this to const field = body.querySelectorAll('.field');.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix it
image

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: 7]

If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: 7]

If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: 7]

If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: 7]

If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, your demo link isn't working, you need to make a deploy and check after the demo link
image

const body = document.body;
const allInputs = body.querySelectorAll('input')
const arrayInputs = [...allInputs];
const fielD body.querySelectorAll('.field');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix it
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants