task complete #994
Closed
task complete #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olya-shyian
suggested changes
Apr 19, 2024
src/scripts/main.js
Outdated
| parentForInput.insertBefore(label, input); | ||
| }); | ||
|
|
||
| function capitalizeString(str) { |
There was a problem hiding this comment.
can we write this function shorter? like
str.slice(0, 1).toUpperCase() + str.slice(1),
There was a problem hiding this comment.
Yes, it's easy. But in this case name='firstName' transform to "FirstName" instead of "First Name"
I have to capitalize name and split words - so every word from capital letter.
- For each
inputsetplaceholderbased oninputname. Capitalize it.
src/scripts/main.js
Outdated
| }); | ||
|
|
||
| function capitalizeString(str) { | ||
| const capitalizeStr = str.split('').reduce((acc, char, index) => { |
There was a problem hiding this comment.
don't use 'str', 'func' etc.
write full name please
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK