Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added solution #1029

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

dima-semeniuk
Copy link

Copy link

@SarakhmanFTMentor SarakhmanFTMentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Comment on lines +9 to +15
const empl1Salary = +empl1.dataset['salary']
.replace('$', '')
.replace(',', '');
const empl2Salary = +empl2.dataset['salary']
.replace('$', '')
.replace(',', '');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be better to have these operations placed into map() before sorting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants