Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parse list DOM solution #1549

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

YaroslavYarmoshyk
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the sorting functionality! 🎉 The code meets the core requirements of the task, and the sorting logic is correctly implemented. However, consider refactoring your code to define the sortList and getEmployees functions as specified in the task description. This will make your code more modular and easier to maintain. Keep up the good work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

const employees = [...document.querySelectorAll('li')];

const sortedEmployees = employees.sort(
(a, b) => parseSalary(b.dataset.salary) - parseSalary(a.dataset.salary),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sorting function currently sorts the employees in descending order based on their salary. Ensure that the data-salary attribute is correctly set on each li element in the HTML, as this script relies on it to function correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants