-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solution #1554
base: master
Are you sure you want to change the base?
solution #1554
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
name: Test | ||
|
||
on: | ||
pull_request: | ||
branches: [ master ] | ||
|
||
jobs: | ||
build: | ||
|
||
runs-on: ubuntu-latest | ||
|
||
strategy: | ||
matrix: | ||
node-version: [20.x] | ||
|
||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Use Node.js ${{ matrix.node-version }} | ||
uses: actions/setup-node@v1 | ||
with: | ||
node-version: ${{ matrix.node-version }} | ||
- run: npm install | ||
- run: npm start & sleep 5 && npm test | ||
- name: Upload tests report(cypress mochaawesome merged HTML report) | ||
if: ${{ always() }} | ||
uses: actions/upload-artifact@v2 | ||
with: | ||
name: report | ||
path: reports |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,27 @@ | ||
'use strict'; | ||
|
||
// write code here | ||
const list = document.querySelector('ul'); | ||
|
||
function getSalary(item) { | ||
return Number(item.dataset.salary.split('$').join('').split(',').join('')); | ||
} | ||
|
||
function sortList() { | ||
const items = [...list.children]; | ||
|
||
items.sort((a, b) => getSalary(b) - getSalary(a)); | ||
|
||
list.append(...items); | ||
} | ||
|
||
function getEmployees() { | ||
return [...list.children].map((item) => ({ | ||
name: item.textContent.trim(), | ||
position: item.dataset.position, | ||
salary: getSalary(item), | ||
age: Number(item.dataset.age), | ||
})); | ||
} | ||
|
||
sortList(list); | ||
getEmployees(list); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
sortList
function is called with a parameterlist
, but the function definition does not accept any parameters and uses thelist
variable directly from the outer scope. Consider removing the parameter from the function call.