This task was hard #1282

Sasha1256 · 2025-01-22T07:59:57Z

No description provided.

mateacademy-ai-mentor

Thank you for your hard work on this project! 😊 While you've made great progress, there are a few critical issues that need to be addressed before we can approve the pull request:

Package Naming and Structure: There are multiple typos in the package names and import statements, such as core.basesyntax.tranasctions instead of core.basesyntax.transactions. These need to be corrected to ensure the code compiles and functions correctly.
Data Conversion Logic: In DataConverterImpl, the logic for parsing the quantity is incorrect. The NUMBER constant is being used as a string instead of parsing the actual value from the input data. This needs to be fixed to ensure accurate data conversion.
SOLID Principles: The DateFruits class is directly accessed by multiple classes, which violates the Dependency Inversion Principle. Consider refactoring to improve adherence to SOLID principles.
Exception Handling: The exception handling in FileReaderImpl and FileWriterImpl could be more informative. Providing detailed error messages will help in debugging and maintaining the code.
Purchase Operation Handling: The PurchaseOperation class should check if the resulting balance is positive before saving it in the storage. A RuntimeException should be thrown if the balance is negative.

Once these issues are resolved, your code will be in great shape! Keep up the good work, and don't hesitate to reach out if you need any help. 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

mateacademy-ai-mentor · 2025-01-22T08:04:40Z

src/main/java/core/basesyntax/DataService/DataConverter.java

@@ -0,0 +1,9 @@
+package core.basesyntax.DataService;
+
+import core.basesyntax.tranasctions.FruitTransaction;


There is a typo in the import statement. It should be core.basesyntax.transactions.FruitTransaction instead of core.basesyntax.tranasctions.FruitTransaction. Please correct the package name to ensure the import works correctly.

mateacademy-ai-mentor · 2025-01-22T08:04:40Z

src/main/java/core/basesyntax/DataService/DataConverterImpl.java

@@ -0,0 +1,27 @@
+package core.basesyntax.DataService;
+
+import core.basesyntax.tranasctions.FruitTransaction;


There is a typo in the import statement. It should be core.basesyntax.transactions.FruitTransaction instead of core.basesyntax.tranasctions.FruitTransaction. Please correct the package name to ensure the import works correctly.

mateacademy-ai-mentor · 2025-01-22T08:04:40Z

src/main/java/core/basesyntax/DataService/DataConverterImpl.java

+                .forEach(strings -> {
+                    FruitTransaction fruitTransaction = new FruitTransaction();
+                    fruitTransaction.setFruit(strings[FRUIT_TYPE]);
+                    fruitTransaction.setQuantity(Integer.parseInt(String.valueOf(NUMBER)));


The setQuantity method is incorrectly using String.valueOf(NUMBER). This should be Integer.parseInt(strings[NUMBER]) to correctly parse the quantity from the data.

mateacademy-ai-mentor · 2025-01-22T08:04:41Z

src/main/java/core/basesyntax/DataService/ShopService.java

@@ -0,0 +1,10 @@
+package core.basesyntax.DataService;
+
+import core.basesyntax.tranasctions.FruitTransaction;


There is a typo in the import statement. It should be core.basesyntax.transactions.FruitTransaction instead of core.basesyntax.tranasctions.FruitTransaction. Please correct the package name to ensure the import works correctly.

mateacademy-ai-mentor · 2025-01-22T08:04:41Z

src/main/java/core/basesyntax/DataService/ShopService.java

+package core.basesyntax.DataService;
+
+import core.basesyntax.tranasctions.FruitTransaction;
+import core.basesyntax.tranasctions.OperationStrategy;


There is a typo in the import statement. It should be core.basesyntax.transactions.OperationStrategy instead of core.basesyntax.tranasctions.OperationStrategy. Please correct the package name to ensure the import works correctly.

mateacademy-ai-mentor · 2025-01-22T08:04:42Z

src/main/java/core/basesyntax/tranasctions/OperationStrategy.java

@@ -0,0 +1,5 @@
+package core.basesyntax.tranasctions;


There is a typo in the package declaration. It should be package core.basesyntax.transactions; instead of package core.basesyntax.tranasctions;. Please correct the package name to ensure consistency and proper functionality.

mateacademy-ai-mentor · 2025-01-22T08:04:42Z

src/main/java/core/basesyntax/tranasctions/OperationStrategyImpl.java

@@ -0,0 +1,15 @@
+package core.basesyntax.tranasctions;


There is a typo in the package declaration. It should be package core.basesyntax.transactions; instead of package core.basesyntax.tranasctions;. Please correct the package name to ensure consistency and proper functionality.

mateacademy-ai-mentor · 2025-01-22T08:04:42Z

src/main/java/core/basesyntax/tranasctions/PurchaseOperation.java

@@ -0,0 +1,12 @@
+package core.basesyntax.tranasctions;


There is a typo in the package declaration. It should be package core.basesyntax.transactions; instead of package core.basesyntax.tranasctions;. Please correct the package name to ensure consistency and proper functionality.

mateacademy-ai-mentor · 2025-01-22T08:04:42Z

src/main/java/core/basesyntax/tranasctions/ReturnOperation.java

@@ -0,0 +1,12 @@
+package core.basesyntax.tranasctions;


There is a typo in the package declaration. It should be package core.basesyntax.transactions; instead of package core.basesyntax.tranasctions;. Please correct the package name to ensure consistency and proper functionality.

mateacademy-ai-mentor · 2025-01-22T08:04:42Z

src/main/java/core/basesyntax/tranasctions/SupplyOperation.java

@@ -0,0 +1,12 @@
+package core.basesyntax.tranasctions;


There is a typo in the package declaration. It should be package core.basesyntax.transactions; instead of package core.basesyntax.tranasctions;. Please correct the package name to ensure consistency and proper functionality.

mateacademy-ai-mentor

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

Something went wrong while processing the review.
_{[CODE: 3]}

If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.

Please help me

mateacademy-ai-mentor

Thank you for your submission! 🎉 While your code has been approved to help you move forward with your learning, there are several important issues that need to be addressed:

Package Naming: The package name fileservise is misspelled and should be corrected to fileservice to adhere to naming conventions.
SOLID Principles: Direct access to DateFruits violates the Dependency Inversion Principle. Consider using an abstraction or interface for accessing the storage to improve adherence to SOLID principles.
Exception Handling: In FileReaderImpl and FileWriterImpl, exceptions are rethrown as RuntimeException without informative messages. Enhance exception handling to provide more context.
Purchase Operation: The PurchaseOperation class lacks a check to ensure the resulting balance is not negative. Implement a check and throw a RuntimeException if the balance is negative.
Operation Handling: Consider adding a check in OperationStrategyImpl to handle cases where the operation is not found in the map, preventing potential NullPointerExceptions.
Business Logic in Main Method: The HelloWorld.java file contains business logic in the main method. Refactor this logic into separate methods or classes for better readability and maintainability.

Please review these comments and make the necessary improvements to enhance your code quality. Keep up the good work and continue learning from these experiences! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

mateacademy-ai-mentor · 2025-01-22T09:43:39Z

src/main/java/core/basesyntax/HelloWorld.java

+import core.basesyntax.dataservice.DataConverterImpl;
+import core.basesyntax.dataservice.ShopService;
+import core.basesyntax.dataservice.ShopServiceImpl;
+import core.basesyntax.fileservise.FileReader;


The package name fileservise is misspelled. It should be fileservice to match the correct naming convention.

mateacademy-ai-mentor · 2025-01-22T09:43:39Z

src/main/java/core/basesyntax/HelloWorld.java

+import core.basesyntax.dataservice.ShopService;
+import core.basesyntax.dataservice.ShopServiceImpl;
+import core.basesyntax.fileservise.FileReader;
+import core.basesyntax.fileservise.FileReaderImpl;


The package name fileservise is misspelled. It should be fileservice to match the correct naming convention.

mateacademy-ai-mentor · 2025-01-22T09:43:39Z

src/main/java/core/basesyntax/HelloWorld.java

+import core.basesyntax.dataservice.ShopServiceImpl;
+import core.basesyntax.fileservise.FileReader;
+import core.basesyntax.fileservise.FileReaderImpl;
+import core.basesyntax.fileservise.FileWriter;


The package name fileservise is misspelled. It should be fileservice to match the correct naming convention.

mateacademy-ai-mentor · 2025-01-22T09:43:39Z

src/main/java/core/basesyntax/HelloWorld.java

+import core.basesyntax.fileservise.FileReader;
+import core.basesyntax.fileservise.FileReaderImpl;
+import core.basesyntax.fileservise.FileWriter;
+import core.basesyntax.fileservise.FileWriterImpl;


The package name fileservise is misspelled. It should be fileservice to match the correct naming convention.

mateacademy-ai-mentor · 2025-01-22T09:43:39Z

src/main/java/core/basesyntax/HelloWorld.java

+    public static void main(String[] args) {
+
+        FileReader fileReader = new FileReaderImpl();
+        List<String> inputReport = fileReader.readFile("reportToRead.csv");
+
+        DataConverter dataConverter = new DataConverterImpl();
+        List<FruitTransaction> transactions = dataConverter.convertToTransaction(inputReport);
+
+        Map<FruitTransaction.Operation, OperationHandler> operationHandlers = new HashMap<>();
+        operationHandlers.put(FruitTransaction.Operation.BALANCE, new BalanceOperation());
+        operationHandlers.put(FruitTransaction.Operation.PURCHASE, new PurchaseOperation());
+        operationHandlers.put(FruitTransaction.Operation.RETURN, new ReturnOperation());
+        operationHandlers.put(FruitTransaction.Operation.SUPPLY, new SupplyOperation());
+        OperationStrategy operationStrategy = new OperationStrategyImpl(operationHandlers);
+
+        ShopService shopService = new ShopServiceImpl(operationStrategy);
+        shopService.process(transactions);
+
+        ReportGenerator reportGenerator = new ReportGeneratorImpl();
+        String resultingReport = reportGenerator.getReport();
+
+        FileWriter fileWriter = new FileWriterImpl();
+        fileWriter.writeFile(resultingReport, "finalReport.csv");
+    }


The main method contains business logic, which is not recommended. Consider refactoring this logic into separate methods or classes to improve code readability and maintainability.

mateacademy-ai-mentor · 2025-01-22T09:43:40Z

src/main/java/core/basesyntax/reportservice/ReportGeneratorImpl.java

@@ -0,0 +1,13 @@
+package core.basesyntax.reportservice;
+
+import core.basesyntax.storage.DateFruits;


Direct access to DateFruits may violate the Dependency Inversion Principle. Consider using an abstraction or interface to access the storage, which would improve adherence to SOLID principles.

mateacademy-ai-mentor · 2025-01-22T09:43:40Z

src/main/java/core/basesyntax/storage/DateFruits.java

+        return fruitsStorage.get(name) == null ? 0 : fruitsStorage.get(name);
+    }
+
+    public static Map<String, Integer> getAll() {


The method getAll() returns a copy of the storage map, which is good for encapsulation. However, consider using an interface or abstraction for accessing the storage to adhere to the Dependency Inversion Principle.

mateacademy-ai-mentor · 2025-01-22T09:43:41Z

src/main/java/core/basesyntax/transactions/BalanceOperation.java

@@ -0,0 +1,17 @@
+package core.basesyntax.transactions;
+
+import core.basesyntax.storage.DateFruits;


Direct access to DateFruits may violate the Dependency Inversion Principle. Consider using an abstraction or interface to access the storage, which would improve adherence to SOLID principles.

mateacademy-ai-mentor · 2025-01-22T09:43:41Z

src/main/java/core/basesyntax/transactions/OperationStrategyImpl.java

+
+    @Override
+    public OperationHandler getOperation(FruitTransaction.Operation operation) {
+        return operationHandlerMap.get(operation);


Consider adding a check to handle cases where the operation is not found in the operationHandlerMap. This could prevent potential NullPointerExceptions and improve robustness.

mateacademy-ai-mentor · 2025-01-22T09:43:41Z

src/main/java/core/basesyntax/transactions/PurchaseOperation.java

+    @Override
+    public void resultOfOperation(String fruitName, int amount) {
+        int currentAmount = DateFruits.get(fruitName);
+        int newAmount = currentAmount - amount;


Before saving the new amount, ensure that newAmount is not negative. If it is, throw a RuntimeException to prevent the storage from having a negative balance, as per the task requirements.

Please help me

liliia-ponomarenko

Firstly let’s fix the build ;) If you have any issues let's discuss them in the chat on the platform

liliia-ponomarenko · 2025-01-23T07:19:58Z

src/main/java/core/basesyntax/HelloWorld.java

+        DataConverter dataConverter = new DataConverterImpl();
+        List<FruitTransaction> transactions = dataConverter.convertToTransaction(inputReport);
+
+        Map<FruitTransaction.Operation, OperationHandler> operationHandlers = new HashMap<>();
+        operationHandlers.put(FruitTransaction.Operation.BALANCE, new BalanceOperation());
+        operationHandlers.put(FruitTransaction.Operation.PURCHASE, new PurchaseOperation());
+        operationHandlers.put(FruitTransaction.Operation.RETURN, new ReturnOperation());
+        operationHandlers.put(FruitTransaction.Operation.SUPPLY, new SupplyOperation());
+        OperationStrategy operationStrategy = new OperationStrategyImpl(operationHandlers);
+
+        ShopService shopService = new ShopServiceImpl(operationStrategy);
+        shopService.process(transactions);
+


Suggested change

DataConverter dataConverter = new DataConverterImpl();

List<FruitTransaction> transactions = dataConverter.convertToTransaction(inputReport);

Map<FruitTransaction.Operation, OperationHandler> operationHandlers = new HashMap<>();

operationHandlers.put(FruitTransaction.Operation.BALANCE, new BalanceOperation());

operationHandlers.put(FruitTransaction.Operation.PURCHASE, new PurchaseOperation());

operationHandlers.put(FruitTransaction.Operation.RETURN, new ReturnOperation());

operationHandlers.put(FruitTransaction.Operation.SUPPLY, new SupplyOperation());

OperationStrategy operationStrategy = new OperationStrategyImpl(operationHandlers);

ShopService shopService = new ShopServiceImpl(operationStrategy);

shopService.process(transactions);

Map<FruitTransaction.Operation, OperationHandler> operationHandlers = new HashMap<>();

operationHandlers.put(FruitTransaction.Operation.BALANCE, new BalanceOperation());

operationHandlers.put(FruitTransaction.Operation.PURCHASE, new PurchaseOperation());

operationHandlers.put(FruitTransaction.Operation.RETURN, new ReturnOperation());

operationHandlers.put(FruitTransaction.Operation.SUPPLY, new SupplyOperation());

OperationStrategy operationStrategy = new OperationStrategyImpl(operationHandlers);

DataConverter dataConverter = new DataConverterImpl();

List<FruitTransaction> transactions = dataConverter.convertToTransaction(inputReport);

ShopService shopService = new ShopServiceImpl(operationStrategy);

shopService.process(transactions);

Or move operationHandlers initialization to the private method

Please help me

liliia-ponomarenko

Good job! Let’s improve your solution ;)

liliia-ponomarenko · 2025-01-23T08:47:08Z

finalReport.csv

+fruit,quantity
+apple,90
+banana,152


move all files to the resources directory

fix comment

liliia-ponomarenko · 2025-01-23T08:47:34Z

pom.xml

+        <dependency>
+            <groupId>org.junit.jupiter</groupId>
+            <artifactId>junit-jupiter</artifactId>
+            <version>RELEASE</version>
+            <scope>test</scope>
+        </dependency>


you don’t need this dependency for this HW

liliia-ponomarenko · 2025-01-23T08:48:01Z

src/main/java/core/basesyntax/HelloWorld.java

+    // HINT: In the `public static void main(String[] args)`
+    // it is better to create instances of your classes,
+    // and call their methods, but do not write any business
+    // logic in the `main` method!


Suggested change

// HINT: In the `public static void main(String[] args)`

// it is better to create instances of your classes,

// and call their methods, but do not write any business

// logic in the `main` method!

remove redundant brackets

liliia-ponomarenko · 2025-01-23T08:48:41Z

src/main/java/core/basesyntax/HelloWorld.java

+    // logic in the `main` method!
+    public static void main(String[] args) {
+        FileReader fileReader = new FileReaderImpl();
+        List<String> inputReport = fileReader.readFile("reportToRead.csv");


move the file path to the constant fields

liliia-ponomarenko · 2025-01-23T08:48:52Z

src/main/java/core/basesyntax/HelloWorld.java

+        String resultingReport = reportGenerator.getReport();
+
+        FileWriter fileWriter = new FileWriterImpl();
+        fileWriter.writeFile(resultingReport, "finalReport.csv");


liliia-ponomarenko · 2025-01-23T08:53:06Z

src/main/java/core/basesyntax/fileservice/FileWriterImpl.java

+        } catch (IOException e) {
+            throw new RuntimeException(e);
+        }
+


Suggested change

liliia-ponomarenko · 2025-01-23T08:53:58Z

src/main/java/core/basesyntax/reportservice/ReportGeneratorImpl.java

+        return "fruit,quantity" + "\n" + DateFruits.getAll().entrySet().stream()
+                .map(element -> element.getKey() + "," + element.getValue())
+                .collect(Collectors.joining("\n"));


Create constants for literals. Use System.lineseparator()
What is bad with this type of concatenation?

liliia-ponomarenko · 2025-01-23T08:56:33Z

src/main/java/core/basesyntax/transactions/BalanceOperation.java

+        if (amount > 0) {
+            int currentAmount = DateFruits.get(fruitName);
+            int newAmount = currentAmount + amount;
+            DateFruits.save(fruitName, newAmount);
+
+        } else {
+            throw new RuntimeException(" The balance can`t be less or equals zero");
+        }


better avoid if-else construction

Suggested change

if (amount > 0) {

int currentAmount = DateFruits.get(fruitName);

int newAmount = currentAmount + amount;

DateFruits.save(fruitName, newAmount);

} else {

throw new RuntimeException(" The balance can`t be less or equals zero");

}

if (amount <= 0) {

throw new RuntimeException(" The balance can`t be less or equals zero");

}

int currentAmount = DateFruits.get(fruitName);

int newAmount = currentAmount + amount;

DateFruits.save(fruitName, newAmount);

fix it for other handlers

liliia-ponomarenko · 2025-01-23T08:57:12Z

src/main/java/core/basesyntax/transactions/FruitTransaction.java

+    private String fruit;
+    private int quantity;
+
+    // getters, setters, ...


Suggested change

// getters, setters, ...

liliia-ponomarenko · 2025-01-23T08:58:04Z

src/main/java/core/basesyntax/transactions/OperationStrategyImpl.java

+        if (operationHandlerMap.get(operation) != null) {
+            return operationHandlerMap.get(operation);
+        } else {
+            throw new RuntimeException("Operation can`t be null");
+        }


the same. provide a parameter in the exception message

Please help me

Elena-Bruyako · 2025-01-23T15:28:39Z

finalReport.csv

+fruit,quantity
+apple,90
+banana,152


fix comment

Elena-Bruyako · 2025-01-23T15:28:53Z

reportToRead.csv

@@ -0,0 +1,8 @@
+b,banana,20


move ro resources folder

Elena-Bruyako · 2025-01-23T15:29:32Z

src/main/java/core/basesyntax/fileservice/FileWriterImpl.java

+                     = new BufferedWriter(new java.io.FileWriter(nameOfNewFile))) {
+            bufferedWriter.write(report);
+        } catch (IOException e) {
+            throw new RuntimeException(e);


fix comment

Elena-Bruyako · 2025-01-23T15:29:56Z

src/main/java/core/basesyntax/reportservice/ReportGeneratorImpl.java

+
+    @Override
+    public String getReport() {
+        return FRUIT + "," + QUANTITY + System.lineSeparator()


it's better to use StringBuilder

JJJazl

Left some comments, but I think you can move on. Please, fix them all before your next task.

JJJazl · 2025-01-24T10:01:32Z

src/main/java/core/basesyntax/storage/DateFruits.java

+import java.util.HashMap;
+import java.util.Map;
+
+public class DateFruits {


Suggested change

public class DateFruits {

public class Storage {

JJJazl · 2025-01-24T10:01:45Z

src/main/java/core/basesyntax/transactions/BalanceOperation.java

+    @Override
+    public void resultOfOperation(String fruitName, int amount) {
+        if (amount <= 0) {
+            throw new RuntimeException(" The balance can`t be less or equals zero");


Suggested change

throw new RuntimeException(" The balance can`t be less or equals zero");

throw new IllegalArgumentException(" The balance can`t be less or equals zero");

JJJazl · 2025-01-24T10:05:19Z

src/main/java/core/basesyntax/dataservice/DataConverterImpl.java

+                .forEach(strings -> {
+                    FruitTransaction fruitTransaction = new FruitTransaction();
+                    fruitTransaction.setFruit(strings[FRUIT_TYPE]);
+                    fruitTransaction.setQuantity(Integer.parseInt(strings[NUMBER]));


What happens if quantity in not a number? Also we want to check if it's not negative before processing any transaction. It's called fail fast principle. It's better to use for loop and wrap this line in try catch block to throw an IllegalArgumentException

JJJazl · 2025-01-24T10:05:49Z

src/main/java/core/basesyntax/transactions/FruitTransaction.java

+            return Arrays.stream(Operation.values())
+                    .filter(e -> e.getCode().equals(code))
+                    .findFirst()
+                    .orElseThrow(() -> new RuntimeException(("Operation with code [%s] "


Suggested change

.orElseThrow(() -> new RuntimeException(("Operation with code [%s] "

.orElseThrow(() -> new IllegalArgumentException(("Operation with code [%s] "

JJJazl · 2025-01-24T10:06:09Z

src/main/java/core/basesyntax/transactions/OperationStrategyImpl.java

+    @Override
+    public OperationHandler getOperation(FruitTransaction.Operation operation) {
+        if (operationHandlerMap.get(operation) == null) {
+            throw new RuntimeException("Operation can`t be null");


Suggested change

throw new RuntimeException("Operation can`t be null");

throw new IllegalArgumentException("Operation can`t be null");

JJJazl · 2025-01-24T10:06:47Z

src/main/java/core/basesyntax/transactions/SupplyOperation.java

+
+public class SupplyOperation implements OperationHandler {
+    @Override
+    public void resultOfOperation(String fruitName, int amount) {


What happens if amount is negative?

JJJazl · 2025-01-24T10:07:50Z

src/main/java/core/basesyntax/transactions/BalanceOperation.java

+        if (amount <= 0) {
+            throw new RuntimeException(" The balance can`t be less or equals zero");
+        }


Let's move it to separate static or default method in OperationHandler and reuse where we need

JJJazl · 2025-01-24T10:08:09Z

src/main/java/core/basesyntax/transactions/ReturnOperation.java

+
+public class ReturnOperation implements OperationHandler {
+    @Override
+    public void resultOfOperation(String fruitName, int amount) {


What happens if amount is negative?

This task was hard

40c31ca

mateacademy-ai-mentor suggested changes Jan 22, 2025

View reviewed changes

This task was hard

2ddd4ef

Sasha1256 requested a review from mateacademy-ai-mentor January 22, 2025 08:24

mateacademy-ai-mentor reviewed Jan 22, 2025

View reviewed changes

Sasha1256 added 2 commits January 22, 2025 10:37

This task was hard

5480923

I can`t solve one problem in checks build Maven.

b22b91c

Please help me

Sasha1256 requested a review from mateacademy-ai-mentor January 22, 2025 08:46

mateacademy-ai-mentor approved these changes Jan 22, 2025

View reviewed changes

I can`t solve one problem in checks build Maven.

3823a25

Please help me

Sasha1256 requested a review from mateacademy-ai-mentor January 22, 2025 10:23

liliia-ponomarenko suggested changes Jan 23, 2025

View reviewed changes

I can`t solve one problem in checks build Maven.

69d4a73

Please help me

Sasha1256 requested a review from liliia-ponomarenko January 23, 2025 08:05

liliia-ponomarenko suggested changes Jan 23, 2025

View reviewed changes

Sasha1256 added 2 commits January 23, 2025 11:56

I can`t solve one problem in checks build Maven.

8d73989

Please help me

I don`t not how i can use StringBuilder

9a2615d

Sasha1256 requested a review from liliia-ponomarenko January 23, 2025 10:03

Elena-Bruyako suggested changes Jan 23, 2025

View reviewed changes

I fixed your comments

3f607bd

Sasha1256 requested a review from Elena-Bruyako January 24, 2025 08:19

JJJazl approved these changes Jan 24, 2025

View reviewed changes

		@@ -0,0 +1,9 @@
		package core.basesyntax.DataService;

		import core.basesyntax.tranasctions.FruitTransaction;

		@@ -0,0 +1,27 @@
		package core.basesyntax.DataService;

		import core.basesyntax.tranasctions.FruitTransaction;

		@@ -0,0 +1,10 @@
		package core.basesyntax.DataService;

		import core.basesyntax.tranasctions.FruitTransaction;

		@@ -0,0 +1,13 @@
		package core.basesyntax.reportservice;

		import core.basesyntax.storage.DateFruits;

		@@ -0,0 +1,17 @@
		package core.basesyntax.transactions;

		import core.basesyntax.storage.DateFruits;

	throw new RuntimeException(" The balance can`t be less or equals zero");
	throw new IllegalArgumentException(" The balance can`t be less or equals zero");

	.orElseThrow(() -> new RuntimeException(("Operation with code [%s] "
	.orElseThrow(() -> new IllegalArgumentException(("Operation with code [%s] "

	throw new RuntimeException("Operation can`t be null");
	throw new IllegalArgumentException("Operation can`t be null");

This task was hard #1282

Are you sure you want to change the base?

This task was hard #1282

Conversation

Sasha1256 commented Jan 22, 2025

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liliia-ponomarenko left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liliia-ponomarenko left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JJJazl left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment