Develop #1289

MykolaTurak · 2025-02-06T17:36:49Z

No description provided.

mateacademy-ai-mentor

Thank you for your hard work on this project! While you've made a good start, there are several critical issues that need to be addressed to meet the core requirements of the task. 🚀

Uninitialized Variables and Imports: The Main.java file has variables like shopService and transactions that are used without being declared or initialized, which will cause compilation errors. Additionally, classes like ReportGeneratorImpl and FileWriterImpl are used without proper imports or declarations.
Interface Implementations: Classes such as FruitsDaoImpl and InsertListImpl are currently empty and do not implement their respective interfaces. Ensure these classes implement all required methods and provide necessary logic.
Constructor and Initialization Issues: The FruitServiceImpl class has issues with the initialization of fruitUseServiceMap, and the Fruit class constructor only initializes the amount field. These need to be addressed for proper functionality.
Project Structure and Redundancies: There are redundant method declarations and typos in class names and parameter names that need correction for clarity and consistency.
Core Functionality: The code lacks implementations for reading from and writing to CSV files, which are essential for the task. Additionally, exception handling and null checks are necessary to prevent potential runtime errors.

Please address these issues to ensure the code meets the task requirements. Keep up the great effort, and don't hesitate to reach out if you need further guidance! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

mateacademy-ai-mentor · 2025-02-06T17:40:33Z

src/main/java/core/basesyntax/Main.java

+
+        // 4. Process the incoming transactions with applicable OperationHandler implementations
+
+        shopService.process(transactions);


The variable shopService is used here but is not declared or initialized anywhere in the code. You need to declare and initialize shopService before using it.

mateacademy-ai-mentor · 2025-02-06T17:40:33Z

src/main/java/core/basesyntax/Main.java

+
+        // 4. Process the incoming transactions with applicable OperationHandler implementations
+
+        shopService.process(transactions);


The variable transactions is used here but is not declared or initialized anywhere in the code. You need to declare and initialize transactions before using it.

mateacademy-ai-mentor · 2025-02-06T17:40:33Z

src/main/java/core/basesyntax/Main.java

+        shopService.process(transactions);
+
+        // 5.Generate report based on the current Storage state
+        ReportGenerator reportGenerator = new ReportGeneratorImpl();


The class ReportGeneratorImpl is used here but is not imported or declared anywhere in the code. Ensure that ReportGeneratorImpl is properly imported or declared.

mateacademy-ai-mentor · 2025-02-06T17:40:34Z

src/main/java/core/basesyntax/Main.java

+        String resultingReport = reportGenerator.getReport();
+
+        // 6. Write the received report into the destination file
+        FileWriter fileWriter = new FileWriterImpl();


The class FileWriterImpl is used here but is not imported or declared anywhere in the code. Ensure that FileWriterImpl is properly imported or declared.

mateacademy-ai-mentor · 2025-02-06T17:40:34Z

src/main/java/core/basesyntax/infratructure/db/FruitsDao.java

+import java.util.List;
+
+public interface FruitsDao {
+  void setFruits(String fruitName);


The setFruits method currently only accepts a String parameter for the fruit name. Consider whether additional parameters, such as quantity or a fruit object, are needed to effectively set fruits in the database.

mateacademy-ai-mentor · 2025-02-06T17:40:35Z

src/main/java/core/basesyntax/service/usecases/PushareFruitImpl.java

+        if (amount > fruitRepository.getFruit(fruitName).getAmount()) {
+            throw new RuntimeException("As much product is not available");
+        }
+        fruitRepository.getFruit(fruitName)


The method fruitRepository.getFruit(fruitName) is called multiple times. Consider storing the result in a variable to avoid redundant method calls and improve performance.

mateacademy-ai-mentor · 2025-02-06T17:40:36Z

src/main/java/core/basesyntax/service/usecases/ReturnFruitToBalance.java

+import core.basesyntax.infratructure.persistence.FruitRepository;
+
+public interface ReturnFruitToBalance extends FruitUseService {
+    void run(String fruitName, int amount);


The run method is already defined in the FruitUseService interface. Redefining it here without any changes or additional documentation is redundant. Consider removing this method declaration.

mateacademy-ai-mentor · 2025-02-06T17:40:36Z

src/main/java/core/basesyntax/service/usecases/ReturnFruitToBalanceImpl.java

+
+    @Override
+    public void run(String fruitName, int amount) {
+        fruitRepository.getFruit(fruitName)


The method fruitRepository.getFruit(fruitName) is called multiple times. Consider storing the result in a variable to avoid redundant method calls and improve performance.

mateacademy-ai-mentor · 2025-02-06T17:40:36Z

src/main/java/core/basesyntax/service/usecases/SupplyFruitToBalance.java

+package core.basesyntax.service.usecases;
+
+public interface SupplyFruitToBalance extends FruitUseService {
+    void run(String fruitName, int amount);


The run method is already defined in the FruitUseService interface. Redefining it here without any changes or additional documentation is redundant. Consider removing this method declaration.

mateacademy-ai-mentor · 2025-02-06T17:40:36Z

src/main/java/core/basesyntax/service/usecases/SupplyFruitToBalanceImpl.java

+
+    @Override
+    public void run(String fruitName, int amount) {
+        fruitRepository.getFruit(fruitName)


The method fruitRepository.getFruit(fruitName) is called multiple times. Consider storing the result in a variable to avoid redundant method calls and improve performance.

mateacademy-ai-mentor

Great job on implementing the core functionality of the code! 🎉 While there are several areas for improvement, such as enhancing exception messages for clarity and correcting typos in class and interface names, the decision to approve this pull request is to help you move forward with your learning journey.

Key Points to Address:

Exception Handling: Improve the specificity of exception messages. For example, include details like the fruit name or operation that failed to make debugging easier.
Typographical Errors: Correct typos in class and interface names, such as PushareFruitImpl to PurchaseFruitImpl and FruitUseReposetory to FruitUseRepository, to maintain consistency and clarity.
Method Redundancies: Avoid redefining methods in interfaces when they are already inherited, such as the run method in interfaces extending FruitUseService.
Error Handling: Implement checks and error handling for potential exceptions like NullPointerException, NumberFormatException, and ArrayIndexOutOfBoundsException.
Resource Management: Use try-with-resources for file operations to ensure proper resource management and prevent leaks.

By addressing these issues, you can enhance the robustness and maintainability of your code. Keep up the good work, and continue learning from these experiences! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

mateacademy-ai-mentor · 2025-02-06T18:15:06Z

src/main/java/core/basesyntax/Main.java

+        try {
+            allData = fruitsDao.getFruits();
+        } catch (IOException e) {
+            throw new RuntimeException("Can't read from DB");


The exception handling here is too generic. Consider providing more detailed information in the exception message to aid in debugging.

mateacademy-ai-mentor · 2025-02-06T18:15:06Z

src/main/java/core/basesyntax/Main.java

+        fruitUseServiceMap
+                .put(Operation.SUPPLY, new SupplyFruitToBalanceImpl(fruitRepository));
+        fruitUseServiceMap
+                .put(Operation.PURCHASE, new PushareFruitImpl(fruitRepository));


There seems to be a typo in the class name PushareFruitImpl. It should likely be PurchaseFruitImpl. Verify the class name and ensure it is correctly implemented.

mateacademy-ai-mentor · 2025-02-06T18:15:06Z

src/main/java/core/basesyntax/Main.java

+        try {
+            fruitsDao.setFruits(fruitService.getFruitRepository().getFruitMap());
+        } catch (IOException e) {
+            throw new RuntimeException("Can't write into DB");


Similar to the previous exception handling, provide more detailed information in the exception message to aid in debugging.

mateacademy-ai-mentor · 2025-02-06T18:15:07Z

src/main/java/core/basesyntax/infratructure/db/FruitsDaoImpl.java

+                .map(fruit -> fruit.getName() + "," + fruit.getAmount())
+                .toList();
+
+        BufferedWriter br = new BufferedWriter(new FileWriter(FILE_NAME));


Consider using a try-with-resources statement for BufferedWriter to ensure that the resource is closed automatically, even if an exception occurs. This will improve resource management and prevent potential resource leaks.

mateacademy-ai-mentor · 2025-02-06T18:15:07Z

src/main/java/core/basesyntax/infratructure/db/InsertListImpl.java

+
+    @Override
+    public void writeInfo(Operation operation, String fruitName, int amount) throws IOException {
+        BufferedWriter br = new BufferedWriter(new FileWriter(FILE_NAME, true));


Consider using a try-with-resources statement for BufferedWriter to ensure that the resource is closed automatically, even if an exception occurs. This will improve resource management and prevent potential resource leaks.

mateacademy-ai-mentor · 2025-02-06T18:15:08Z

src/main/java/core/basesyntax/service/usecases/ReturnFruitToBalanceImpl.java

+import core.basesyntax.service.Operation;
+import java.io.IOException;
+
+public class ReturnFruitToBalanceImpl extends FruitUseReposetory implements ReturnFruitToBalance {


There is a typo in the superclass name FruitUseReposetory. It should be FruitUseRepository. Correct the spelling to maintain consistency and clarity.

mateacademy-ai-mentor · 2025-02-06T18:15:08Z

src/main/java/core/basesyntax/service/usecases/ReturnFruitToBalanceImpl.java

+        try {
+            super.getInsertListDao().writeInfo(Operation.RETURN, fruitName, amount);
+        } catch (IOException e) {
+            throw new RuntimeException("Can't insert to file");


The exception message 'Can't insert to file' could be more informative. Consider including details about the operation that failed.

mateacademy-ai-mentor · 2025-02-06T18:15:08Z

src/main/java/core/basesyntax/service/usecases/SupplyFruitToBalance.java

+package core.basesyntax.service.usecases;
+
+public interface SupplyFruitToBalance extends FruitUseService {
+    void run(String fruitName, int amount);


Redefining the run method in this interface is unnecessary since it already inherits from FruitUseService. Consider removing the method declaration here.

mateacademy-ai-mentor · 2025-02-06T18:15:08Z

src/main/java/core/basesyntax/service/usecases/SupplyFruitToBalanceImpl.java

+import core.basesyntax.service.Operation;
+import java.io.IOException;
+
+public class SupplyFruitToBalanceImpl extends FruitUseReposetory implements SupplyFruitToBalance {


There is a typo in the superclass name FruitUseReposetory. It should be FruitUseRepository. Correct the spelling to maintain consistency and clarity.

mateacademy-ai-mentor · 2025-02-06T18:15:08Z

src/main/java/core/basesyntax/service/usecases/SupplyFruitToBalanceImpl.java

+        try {
+            super.getInsertListDao().writeInfo(Operation.SUPPLY, fruitName, amount);
+        } catch (IOException e) {
+            throw new RuntimeException("Can't insert to file");


The exception message 'Can't insert to file' could be more informative. Consider including details about the operation that failed.

liliia-ponomarenko

Let’s check task requirements! Compare the input and output file structures with your files. Let’s fix it! Check the example of the Main class, service names, and responsibility

liliia-ponomarenko

Let’s improve your solution ;)

liliia-ponomarenko · 2025-02-07T16:56:23Z

src/main/java/core/basesyntax/Main.java

+        try {
+            fileWriter.write(resultingReport);
+        } catch (IOException e) {
+            throw new RuntimeException("Can't write report into db");
+        }


Catch exception in writer service. add file name parameter to the exception message

liliia-ponomarenko · 2025-02-07T16:57:52Z

src/main/java/core/basesyntax/infrastructure/DataConverterImpl.java

+    @Override
+    public List<FruitTransaction> convertToTransaction(List<String> inputReport) {
+        return inputReport.stream()
+                .map(s -> s.split(","))


move the separator to the constant fields

liliia-ponomarenko · 2025-02-07T16:58:31Z

src/main/java/core/basesyntax/infrastructure/DataConverterImpl.java

+        return inputReport.stream()
+                .map(s -> s.split(","))
+                .map(s -> new FruitTransaction(
+                        FruitTransaction.getOperation(s[0]), s[1], Integer.parseInt(s[2])))


better validate data. check that quantity is number

liliia-ponomarenko · 2025-02-07T16:59:38Z

src/main/java/core/basesyntax/infrastructure/db/FileReaderImpl.java

+    }
+
+    @Override
+    public List<String> read() {


pass file name as a method parameter. Add a parameter to the method message

liliia-ponomarenko · 2025-02-07T17:00:16Z

src/main/java/core/basesyntax/infrastructure/db/FileReaderImpl.java

+    @Override
+    public void setFruits(Map<String, Fruit> fruitMap) throws IOException {
+        List<String> data = fruitMap.entrySet().stream()
+                .map(m -> m.getValue())
+                .map(fruit -> fruit.getName() + "," + fruit.getAmount())
+                .toList();
+
+        BufferedWriter br = new BufferedWriter(new FileWriter(FILE_NAME));
+        for (String str : data) {
+            br.write(str + System.lineSeparator());
+        }
+        br.close();
+    }


It's not reader logic

liliia-ponomarenko · 2025-02-07T17:07:38Z

src/main/java/core/basesyntax/service/operations/BalanceOperation.java

+public class BalanceOperation implements OperationHandler {
+
+    @Override
+    public void run(FruitTransaction fruitTransaction, Map<String, Integer> fruitRepository) {


the same use Storage

liliia-ponomarenko · 2025-02-07T17:08:43Z

src/main/java/core/basesyntax/service/operations/PurchaseOperation.java

+            throw new NoSuchElementException();
+        }
+        fruitRepository.replace(fruitTransaction.getFruit(),
+                fruitRepository.get(fruitTransaction.getFruit()) - fruitTransaction.getQuantity());


What happens if fruit quantity isn’t enough?

liliia-ponomarenko · 2025-02-07T17:08:52Z

src/main/java/core/basesyntax/service/operations/PurchaseOperation.java

+    @Override
+    public void run(FruitTransaction fruitTransaction, Map<String, Integer> fruitRepository) {
+        if (fruitRepository.get(fruitTransaction.getFruit()) == null) {
+            throw new NoSuchElementException();


add message

liliia-ponomarenko · 2025-02-07T17:09:26Z

src/main/java/core/basesyntax/service/operations/ReturnOperation.java

+    @Override
+    public void run(FruitTransaction fruitTransaction, Map<String, Integer> fruitRepository) {
+        if (fruitRepository.get(fruitTransaction.getFruit()) == null) {
+        //     throw new NoSuchElementException();


remove commented code and block without realization

liliia-ponomarenko · 2025-02-07T17:09:39Z

src/main/java/core/basesyntax/service/operations/SupplyOperation.java

+    public void run(FruitTransaction fruitTransaction, Map<String, Integer> fruitRepository) {
+        if (fruitRepository.get(fruitTransaction.getFruit()) == null) {
+            throw new NoSuchElementException();


the same comments

Elena-Bruyako · 2025-02-08T17:50:12Z

src/main/java/core/basesyntax/Main.java

+    public static void main(String[] arg) {
+        // 1. Read the data from the input CSV file
+        FileReader fileReader = new FileReaderImpl();
+        List<String> inputReport = fileReader.read("src/main/java/operationslist.csv");


create constant for file path

Elena-Bruyako · 2025-02-08T17:50:19Z

src/main/java/core/basesyntax/Main.java

+
+public class Main {
+    public static void main(String[] arg) {
+        // 1. Read the data from the input CSV file


remove comments

Elena-Bruyako · 2025-02-08T17:50:35Z

src/main/java/core/basesyntax/Main.java

+
+        // 6. Write the received report into the destination file
+        FileWriter fileWriter = new FileWriterImpl();
+        fileWriter.write(resultingReport, "src/main/java/database.csv");


Elena-Bruyako · 2025-02-08T17:50:44Z

src/main/java/core/basesyntax/infrastructure/DataConverterImpl.java

+    public List<FruitTransaction> convertToTransaction(List<String> inputReport) {
+        return inputReport.stream()
+                .map(s -> s.split(SEPARATOR))
+                .filter(s -> s.length == 3 && isNumeric(s[2])) // Перевіряємо довжину та чи є число


remove comments

Elena-Bruyako · 2025-02-08T17:51:04Z

src/main/java/core/basesyntax/infrastructure/DataConverterImpl.java

+    public List<FruitTransaction> convertToTransaction(List<String> inputReport) {
+        return inputReport.stream()
+                .map(s -> s.split(SEPARATOR))
+                .filter(s -> s.length == 3 && isNumeric(s[2])) // Перевіряємо довжину та чи є число


rename s
create constants for all magic numbers

Elena-Bruyako · 2025-02-09T11:51:42Z

src/main/java/core/basesyntax/Main.java

+import java.util.Map;
+
+public class Main {
+    private static final String OPERATION_LIST_FILE_PATH = "src/main/java/operationslist.csv";


files should be stored in resources folder

liliia-ponomarenko

Firstly, let’s fix the build

Elena-Bruyako

few comments

Elena-Bruyako · 2025-02-11T08:20:16Z

src/main/java/core/basesyntax/Main.java

+
+public class Main {
+    private static final String OPERATION_LIST_FILE_PATH
+            = "src/main/java/core/basesyntax/resources/operationslist.csv";


resources folder should be placed in src/main/resources

Elena-Bruyako · 2025-02-11T08:21:08Z

src/main/java/core/basesyntax/infrastructure/DataConverterImpl.java

+            Integer.parseInt(str);
+            return true;
+        } catch (NumberFormatException e) {
+            return false;


let's throw an exception with message in this case

src/main/java/core/basesyntax/infrastructure/DataConverterImpl.java

src/main/java/core/basesyntax/service/ReportGeneratorImpl.java

src/main/java/core/basesyntax/service/OperationStrategy.java

JJJazl · 2025-02-11T13:50:51Z

src/main/java/core/basesyntax/service/operations/PurchaseOperation.java

+        if (Storage.STORAGE.get(fruitTransaction.getFruit()) == null) {
+            throw new NoSuchElementException("Can't find fruit: " + fruitTransaction.getFruit());
+        }


Let's move it to the default or static method in OperationHandler to avoid code duplication

JJJazl · 2025-02-11T13:53:16Z

src/main/java/core/basesyntax/infrastructure/DataConverterImpl.java

+
+    private boolean isNumeric(String str) {
+        try {
+            Integer.parseInt(str);


What happens if quantity is negative?)
Let's rewrite this method, change return type to int and use it in map(), instead of filter()

JJJazl · 2025-02-11T13:54:34Z

src/main/java/core/basesyntax/service/operations/SupplyOperation.java

+        Storage.STORAGE.replace(fruitTransaction.getFruit(),
+                Storage.STORAGE.get(fruitTransaction.getFruit()) + fruitTransaction.getQuantity());


Let's use put() instead of replace(). See everywhere

….java Co-authored-by: Safarov Renat <[email protected]>

Co-authored-by: Safarov Renat <[email protected]>

Mykola added 2 commits February 6, 2025 17:33

make structure and use cases

c109bec

make task

376f28d

mateacademy-ai-mentor suggested changes Feb 6, 2025

View reviewed changes

Mykola added 2 commits February 6, 2025 19:43

solve style problems

40d5531

solve remarked problems

13dfcc5

MykolaTurak requested a review from mateacademy-ai-mentor February 6, 2025 18:11

mateacademy-ai-mentor approved these changes Feb 6, 2025

View reviewed changes

liliia-ponomarenko suggested changes Feb 7, 2025

View reviewed changes

remade project

5acef2f

MykolaTurak requested a review from liliia-ponomarenko February 7, 2025 13:54

liliia-ponomarenko suggested changes Feb 7, 2025

View reviewed changes

solve remarked problems

8721977

MykolaTurak requested a review from liliia-ponomarenko February 8, 2025 11:58

Elena-Bruyako suggested changes Feb 8, 2025

View reviewed changes

solve remarked problems

6ff2aa5

MykolaTurak requested a review from Elena-Bruyako February 8, 2025 22:04

Elena-Bruyako suggested changes Feb 9, 2025

View reviewed changes

move DB files to resources folder

22cac8c

MykolaTurak requested a review from Elena-Bruyako February 9, 2025 17:02

liliia-ponomarenko suggested changes Feb 10, 2025

View reviewed changes

solve remarked problems

411e32d

MykolaTurak requested a review from liliia-ponomarenko February 10, 2025 10:30

Elena-Bruyako suggested changes Feb 11, 2025

View reviewed changes

solve remarked problems

ad9e05b

MykolaTurak requested a review from Elena-Bruyako February 11, 2025 11:32

JJJazl suggested changes Feb 11, 2025

View reviewed changes

MykolaTurak and others added 4 commits February 11, 2025 22:27

Update src/main/java/core/basesyntax/infrastructure/DataConverterImpl…

3df4ac3

….java Co-authored-by: Safarov Renat <[email protected]>

Update src/main/java/core/basesyntax/service/ReportGeneratorImpl.java

e794b88

Co-authored-by: Safarov Renat <[email protected]>

Update src/main/java/core/basesyntax/service/OperationStrategy.java

f386dad

Co-authored-by: Safarov Renat <[email protected]>

solve remarked problems

db24169

MykolaTurak requested a review from JJJazl February 11, 2025 21:05

sarakhmen approved these changes Feb 12, 2025

View reviewed changes


		// 4. Process the incoming transactions with applicable OperationHandler implementations

		shopService.process(transactions);

		Storage.STORAGE.replace(fruitTransaction.getFruit(),
		Storage.STORAGE.get(fruitTransaction.getFruit()) + fruitTransaction.getQuantity());

Develop #1289

Are you sure you want to change the base?

Develop #1289

Conversation

MykolaTurak commented Feb 6, 2025

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liliia-ponomarenko left a comment

Choose a reason for hiding this comment

liliia-ponomarenko left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liliia-ponomarenko left a comment

Choose a reason for hiding this comment

Elena-Bruyako left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment