Responsive header block complete #2671
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zibi95
suggested changes
Dec 4, 2024
natalia-klonowska
suggested changes
Feb 3, 2025
There was a problem hiding this comment.
- there should be phone number on hover:
- Change text color on hover for phone, email and address:
- Make the phone number and email clickable to start a phone call or compose an email
- Form shouldn't be submitted if some of the fields are not filled
- Page shouldn't be reloaded on form submit (https://developer.mozilla.org/en-US/docs/Web/API/Event/preventDefault)
- Prevent menu links from pushing down other elements when hovered due to the appearance of border-bottom
natalia-klonowska
suggested changes
Feb 4, 2025
There was a problem hiding this comment.
after form submission page redirects to 'Page Not Found' error. you should add js script to prevent page from reloading (https://www.w3schools.com/Jsref/event_preventdefault.asp).
additionally consider clearing inputs (https://www.w3schools.com/Jsref/met_form_reset.asp) or displaying a notification to indicate that submission was successful
natalia-klonowska
suggested changes
Feb 10, 2025
| @@ -312,5 +314,7 @@ <h2 class="contact__title">Contact us</h2> | |||
| </main> | |||
|
|
|||
| <footer class="footer"></footer> | |||
|
|
|||
| <script src="./scripts/main.js"></script> | |||
There was a problem hiding this comment.
masz już podpięty ten skrypt na samej górze w head przez co alert wywołuje się podwójnie ^^"
natalia-klonowska
suggested changes
Feb 10, 2025
src/styles/blocks/header.scss
Outdated
| font-size: 64px; | ||
| line-height: 64px; | ||
|
|
||
| padding-top: 294px; |
There was a problem hiding this comment.
Suggested change
| padding-top: 294px; | |
| padding-top: 342px; |
src/styles/blocks/header.scss
Outdated
|
|
||
| &__icons { | ||
| width: 96px; | ||
| height: 96px; |
There was a problem hiding this comment.
Suggested change
| height: 96px; |
src/styles/blocks/header.scss
Outdated
|
|
||
| &__icons { | ||
| width: 96px; | ||
| height: 96px; |
There was a problem hiding this comment.
Suggested change
| height: 96px; |
src/styles/blocks/header.scss
Outdated
| font-size: 80px; | ||
| line-height: 80px; | ||
|
|
||
| padding-top: 294px; |
There was a problem hiding this comment.
Suggested change
| padding-top: 294px; | |
| padding-top: 336px; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK