-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop- first block #2681
base: master
Are you sure you want to change the base?
Develop- first block #2681
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link do demo wyrzuca 404 :c
Jak masz jakies problemy to zapraszamy na QnA albo pisz na czacie :))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed the project and noticed a few issues that need attention:
-
Header Section:
- The background image quality is poor and needs to be replaced with a higher resolution version
- Consider optimizing the image for web use (compression while maintaining quality)
-
Hours Section:
- The layout is not properly aligned
- Elements need proper spacing and organization
- Consider using CSS Grid or Flexbox for better structure
Recommendation for workflow:
- Please complete one section at a time
- Add comments in the code indicating which sections are ready for review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tutaj przy ekranie 1900px rozdzielczosci kontent rozjezdza ci sie na cała szerokosc ekranu.
Tu na figmie jak widzisz wszystko trzyma sie w tak zwanym kontenerze o szerokosci 1020px
Mozesz osiagnac ten efekt dodajac tam na sekcje klase .container
ktora bedzie wygladac mniej wiecej tak
{ max-width:1020px; width:100%; margin: 0 auto; }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Pictures in Gallery should increase on hover
- Change text color on hover for phone, email and address
- When you click on phone icon or phone number in contacts section, make sure that there is no 404 error, make it a real link to start a call on device
- Page shouldn't be reloaded on form submit (https://developer.mozilla.org/en-US/docs/Web/API/Event/preventDefault)
-text should start with the same margin as the placeholder instead of touching the edges of the input field:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super robota!!!
https://OlkowskaK.github.io/layout_miami/