Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #2683

Open
wants to merge 74 commits into
base: develop
Choose a base branch
from
Open

Develop #2683

wants to merge 74 commits into from

Conversation

Pamcik
Copy link

@Pamcik Pamcik commented Feb 17, 2025

Copy link

@natalia-klonowska natalia-klonowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deploy your project and add demo link to pr description

Copy link

@natalia-klonowska natalia-klonowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checklist

  • Pictures in Gallery should increase on hover
  • disable page scrolling under the menu:
    image

section "Contact us":

  • Change text color on hover for phone, email and address
  • When you click on phone icon or phone number in contacts section, make sure that there is no 404 error, make it a real link to start a call on device
  • When clicking on any location / address - prevent errors and make it to open location in Google Maps
  • Placeholders in the forms suggest what to enter; apply validation of the form fields (required, email / tel etc.), then it is clear in what format to enter the data
  • Form shouldn't be submitted if some of the fields are not filled

Copy link

@danon321 danon321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where link do demo

@Pamcik Pamcik requested a review from danon321 February 18, 2025 16:24
Copy link

@natalia-klonowska natalia-klonowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Form submit takes you to "405 Not Allowed" page
  • Images can overlap when scaled up on hover but the one that is enlarged shouldn't be placed behind the others
    image

Copy link

@natalia-klonowska natalia-klonowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

layout is not responsive it's fixed with breakpoints which results in too large margins between them:
image

Here you can find a comparison between fixed and responsive layouts and here you can see example of responsive layout with breakpoints

Copy link

@danon321 danon321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dobra robota :))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.