Created clock #3073
Open
Created clock #3073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YarynaPuhach
commented
Feb 2, 2024
YarynaPuhach
commented
- DEMO LINK
nataliaklonowska
suggested changes
Feb 2, 2024
Comment on lines
+50
to
+59
| &--speed-up { | ||
| .stopwatch__minutes-hand { | ||
| animation: rotate $min-animation-time-speed-up steps(60) infinite; | ||
| } | ||
|
|
||
| .stopwatch__seconds-hand { | ||
| animation: rotate $sec-animation-time-speed-up linear infinite; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
add modifier inside minutes and seconds class Typical BEM Mistakes
There was a problem hiding this comment.
Przepraszam, ale czy możesz mi powiedzieć, jak to zrobić poprawnie?
Ponieważ tutaj wartości animacji dla testów z klasą stopwatch--speed-up zostały po prostu zmienione.
Ale nie rozumiem, jak nadać animacji inne wartości, pod warunkiem, że istnieje klasa stopwatch--speed-up bezpośrednio w w stopwatch__minutes-hand i stopwatch__seconds-hand?
src/styles/stopwatch.scss
Outdated
Comment on lines
1
to
8
| .page { | ||
| height: 100vh; | ||
| display: flex; | ||
| justify-content: center; | ||
| align-items: center; | ||
| box-sizing: border-box; | ||
| margin: 0; | ||
| } |
There was a problem hiding this comment.
page is not part of stopwatch block Typical BEM Mistakes
nataliaklonowska
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.