Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #3528

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add task solution #3528

wants to merge 1 commit into from

Conversation

OlegMysko
Copy link

  • [ x ] Keyframes implemented using from/to + transform with rotate property
  • [ x ] Stopwatch is centered and has the correct arrows size
  • [ x ] All Typical Mistakes from the BEM lesson theory are checked.
  • [ x ] Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on your implementation! 🎉 The code meets the core requirements, and the stopwatch is functioning well. There are a couple of minor improvements you could make, such as removing unnecessary CSS properties in the keyframes and redundant border styles. Keep up the good work and continue refining your skills! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +18 to +20
border: 1vmin dashed #000;
border-radius: 50%;
border-style: dotted;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The border-style: dotted; is redundant because the border property already specifies the style as dashed. Consider removing this line to avoid confusion.

Comment on lines +71 to +72
transition-duration: 60s;
transition-timing-function: linear;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The transition-duration and transition-timing-function properties are not effective within keyframes. Transitions do not apply to keyframe animations. Consider removing these properties from the keyframes.

Comment on lines +77 to +78
transition-duration: 60s;
transition-timing-function: linear;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The transition-duration and transition-timing-function properties are not effective within keyframes. Transitions do not apply to keyframe animations. Consider removing these properties from the keyframes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants