-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add task solution #3528
base: master
Are you sure you want to change the base?
add task solution #3528
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on your implementation! 🎉 The code meets the core requirements, and the stopwatch is functioning well. There are a couple of minor improvements you could make, such as removing unnecessary CSS properties in the keyframes and redundant border styles. Keep up the good work and continue refining your skills! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
border: 1vmin dashed #000; | ||
border-radius: 50%; | ||
border-style: dotted; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The border-style: dotted;
is redundant because the border
property already specifies the style as dashed
. Consider removing this line to avoid confusion.
transition-duration: 60s; | ||
transition-timing-function: linear; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The transition-duration
and transition-timing-function
properties are not effective within keyframes. Transitions do not apply to keyframe animations. Consider removing these properties from the keyframes.
transition-duration: 60s; | ||
transition-timing-function: linear; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The transition-duration
and transition-timing-function
properties are not effective within keyframes. Transitions do not apply to keyframe animations. Consider removing these properties from the keyframes.
Typical Mistakes
from theBEM
lesson theory are checked.