-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add task solution #3539
base: master
Are you sure you want to change the base?
add task solution #3539
Conversation
kovalmaria
commented
Dec 11, 2024
- DEMO LINK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your hard work on this project! 😊 There are a few critical issues that need to be addressed to ensure the stopwatch functions correctly.
-
Animation Duration for Basic Functionality: The
seconds
hand should have an animation duration of60s
for basic functionality, not10s
. Similarly, theminutes
hand should be set to3600s
instead of600s
. These changes are necessary for the stopwatch to function correctly without thespeed-up
modifier. -
Keyframes Implementation: The
@keyframes rotates
animation should start withtransform: rotate(0deg);
instead ofrotate(1deg);
to ensure the hands start from the correct position.
Please make these adjustments to meet the core requirements of the task. Once these are resolved, your solution will be ready for approval. Keep up the great work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review
button in the Reviewers tab.
src/styles/index.scss
Outdated
@keyframes rotates { | ||
from { | ||
transform: rotate(1deg); | ||
} | ||
to { | ||
transform: rotate(360deg); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The @keyframes rotates
animation starts with transform: rotate(1deg);
. This might cause a slight initial offset in the rotation. Consider starting from transform: rotate(0deg);
to ensure the hands start from the correct position.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on addressing the previous issues! 🎉 Your code now meets the task requirements and constraints. Here are some key points from the review:
- The HTML structure for the stopwatch is correctly set up. Make sure that the
index.scss
file is compiled to CSS and included in the project so that styles are applied correctly. - The SCSS file has been mostly corrected, with the necessary changes for the animation durations of the stopwatch hands. The
@keyframes rotates
animation now starts fromrotate(0deg)
, ensuring the hands start from the correct position. - The
stopwatch--speed-up
class is present in the HTML. Verify if any additional styles or logic are needed for this class, as it may affect the animation speed.
Your solution fulfills the requirements specified in the task description. While there are minor issues to address, the decision to approve is made to help you move forward with your learning. Please review the comments to improve your code, and remember to address any critical issues in the future to avoid similar problems. Keep up the good work and continue learning from your experiences! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨