Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #3539

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add task solution #3539

wants to merge 2 commits into from

Conversation

kovalmaria
Copy link

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your hard work on this project! 😊 There are a few critical issues that need to be addressed to ensure the stopwatch functions correctly.

  1. Animation Duration for Basic Functionality: The seconds hand should have an animation duration of 60s for basic functionality, not 10s. Similarly, the minutes hand should be set to 3600s instead of 600s. These changes are necessary for the stopwatch to function correctly without the speed-up modifier.

  2. Keyframes Implementation: The @keyframes rotates animation should start with transform: rotate(0deg); instead of rotate(1deg); to ensure the hands start from the correct position.

Please make these adjustments to meet the core requirements of the task. Once these are resolved, your solution will be ready for approval. Keep up the great work! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

Comment on lines 56 to 62
@keyframes rotates {
from {
transform: rotate(1deg);
}
to {
transform: rotate(360deg);
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @keyframes rotates animation starts with transform: rotate(1deg);. This might cause a slight initial offset in the rotation. Consider starting from transform: rotate(0deg); to ensure the hands start from the correct position.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on addressing the previous issues! 🎉 Your code now meets the task requirements and constraints. Here are some key points from the review:

  • The HTML structure for the stopwatch is correctly set up. Make sure that the index.scss file is compiled to CSS and included in the project so that styles are applied correctly.
  • The SCSS file has been mostly corrected, with the necessary changes for the animation durations of the stopwatch hands. The @keyframes rotates animation now starts from rotate(0deg), ensuring the hands start from the correct position.
  • The stopwatch--speed-up class is present in the HTML. Verify if any additional styles or logic are needed for this class, as it may affect the animation speed.

Your solution fulfills the requirements specified in the task description. While there are minor issues to address, the decision to approve is made to help you move forward with your learning. Please review the comments to improve your code, and remember to address any critical issues in the future to avoid similar problems. Keep up the good work and continue learning from your experiences! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants