Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create stopwatch task using keyframes #3540

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

galina-palyukh
Copy link

  • DEMO LINK

  • Keyframes implemented using from/to + transform with rotate property

  • Stopwatch is centered and has the correct arrows size

  • All Typical Mistakes from the BEM lesson theory are checked.

  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on meeting the task requirements and constraints! 🎉 Your code is well-structured and functional, with only a minor issue regarding the animation duration calculation in SCSS. Remember to calculate the duration directly in seconds, like 3600s for 60 minutes, to ensure proper functionality. Keep up the excellent work and continue refining your skills! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

width: 3vmin;
height: 20vmin;
background-color: #0700ff;
animation-duration: 60 * 60s;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The animation-duration property is set to '60 * 60s'. This is not a valid SCSS or CSS syntax for multiplication. You should calculate the duration in seconds and set it directly, e.g., '3600s' for 60 minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants