add task solution #3549
add task solution #3549
Conversation
Aweiro
commented
Dec 18, 2024
Aweiro
commented
- DEMO LINK
There was a problem hiding this comment.
Great job on implementing the stopwatch with CSS animations! 🎉 The overall structure and styling are well done. Just a small note: make sure to define the $hands variable correctly as a list or map for your @each loop to work as intended. Keep up the good work and happy coding! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| @each $hand, $i in $hands { | ||
| &__#{$hand}-hand { | ||
| animation-duration: #{$i}; | ||
| } | ||
| } |
There was a problem hiding this comment.
The @each loop references $hands and $i, but these variables are not defined in the provided code. Ensure that $hands is defined as a map or list elsewhere in your SCSS files, or define it here if it's missing.
| @@ -0,0 +1,3 @@ | |||
| $sec: 10s; | |||
| $min: 10min; | |||
| $hands: 'seconds' $sec, 'minutes' $min; | |||
There was a problem hiding this comment.
The $hands variable is intended to be a list or map for use in an @each loop, but the syntax is incorrect. You should define it as a list or map. For example, use a list: ('seconds' $sec, 'minutes' $min) or a map: ('seconds': $sec, 'minutes': $min).
