-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task done #3551
base: master
Are you sure you want to change the base?
task done #3551
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on your implementation! 🎉 The code meets the task requirements well, with a clear structure and correct use of BEM methodology. Just a small note: ensure the class names in the stopwatch--speed-up
modifier block are consistent with the rest of your code. Keep up the good work! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
src/styles/index.scss
Outdated
} | ||
|
||
.stopwatch--speed-up { | ||
.stopwatch__seconds-hand { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The class name .stopwatch__seconds-hand
seems to be incorrect. It should be .stopwatch__second-hand
to match the class defined earlier in the file.
src/styles/index.scss
Outdated
.stopwatch__seconds-hand { | ||
animation-duration: 10s; | ||
} | ||
.stopwatch__min-hand { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The class name .stopwatch__min-hand
seems to be incorrect. It should be .stopwatch__minute-hand
to match the class defined earlier in the file.
DEMO LINK