Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completed task #3593

Closed
wants to merge 10 commits into from
Closed

completed task #3593

wants to merge 10 commits into from

Conversation

apr1ori
Copy link

@apr1ori apr1ori commented Jan 22, 2025

  • Keyframes implemented using from/to + transform with rotate property
  • Stopwatch is centered and has the correct arrows size
  • All Typical Mistakes from the BEM lesson theory are checked.
  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your hard work on this project! 😊 While your code is mostly on point, there are a few critical issues that need to be addressed before we can approve it. The speed-up BEM modifier is missing in the HTML, which is crucial for testing the speed-up functionality. Additionally, the minute hand's animation should use a steps animation with 60 steps, and the speed-up modifier should change the duration to 10 minutes using steps. Lastly, ensure that keyframes use from/to instead of 0%/100%. Please make these changes, and you'll be all set! Keep up the great work! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your hard work on this project! There are a couple of critical issues that need to be addressed before we can approve the pull request. First, there's a typo in the variable name $mh-heigth which should be corrected to $mh-height to ensure consistency and avoid errors. Additionally, the animation for the minute hand should use a steps animation with 60 steps, as specified in the task description. Please make these changes, and you'll be all set! Keep up the great work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

@apr1ori apr1ori closed this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants