add task solution #3596
add task solution #3596
Conversation
IvanRyabukha
commented
Jan 23, 2025
IvanRyabukha
commented
- DEMO LINK
There was a problem hiding this comment.
Great job on implementing the stopwatch functionality! 🎉 The core requirements are met, and the animations and design look fantastic. Just make sure to fix the self-closing <html> tag to ensure valid HTML. Keep up the great work and happy coding! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| @@ -1,5 +1,8 @@ | |||
| <!doctype html> | |||
| <html lang="en"> | |||
| <html | |||
There was a problem hiding this comment.
The <html> tag is incorrectly self-closed. HTML tags like <html> should not be self-closed. Remove the self-closing slash to correct this.
| &__minute { | ||
| position: absolute; | ||
| bottom: 40vmin; | ||
| left: 40vmin - 1.5vmin; |
There was a problem hiding this comment.
The calculation left: 40vmin - 1.5vmin; might not work as expected because CSS does not support arithmetic operations directly. Consider using a preprocessor function or adjust the value manually.
| &__second { | ||
| position: absolute; | ||
| bottom: 40vmin; | ||
| left: 40vmin - 0.75vmin; |
There was a problem hiding this comment.
Similar to the previous comment, the calculation left: 40vmin - 0.75vmin; might not work as expected. Consider using a preprocessor function or adjust the value manually.
|
|
||
| &__center { | ||
| position: absolute; | ||
| top: 40vmin - 2.5vmin; |
There was a problem hiding this comment.
The calculation top: 40vmin - 2.5vmin; might not work as expected. Consider using a preprocessor function or adjust the value manually.
| &__center { | ||
| position: absolute; | ||
| top: 40vmin - 2.5vmin; | ||
| left: 40vmin - 2.5vmin; |
There was a problem hiding this comment.
The calculation left: 40vmin - 2.5vmin; might not work as expected. Consider using a preprocessor function or adjust the value manually.
